mirror of
https://github.com/openai/codex.git
synced 2026-11-15 21:50:46 +00:00
Add a searchable /config preferences panel to the TUI (#52990)
## What changed - Group preferences into Appearance, Notifications, Input, Sessions, and Text selection tabs, with search and links to existing theme, status line, terminal title, and keyboard editors. - Persist preference changes to the selected local configuration file, apply supported changes immediately, and show save errors, configuration overrides, and restart requirements in the panel. - Add a delayed notification test and controls for notification timing while preserving custom event filters. - Add `tui.copy_on_select_clear_selection`, disabled by default, to clear transcript selection highlights only after confirmed automatic clipboard delivery. - Keep local configuration editors usable while disconnected and prevent held activation keys or buffered input from triggering actions across editor and reconnect transitions. ## Testing Add regression tests and rendering snapshots for panel navigation, search, dependency states, editor handoffs, offline persistence, notification timers, custom filter preservation, and confirmed-copy deselection. GitOrigin-RevId: a16d218046060fcb6e61705a803fcd9297266e6e
This commit is contained in:
@@ -291,8 +291,8 @@ impl TranscriptView {
|
||||
}
|
||||
}
|
||||
|
||||
/// Track delivery for the current selection. Explicit copies release it on confirmation;
|
||||
/// automatic copies, failures, and unacknowledged terminal writes retain the revision.
|
||||
/// Deselect only after confirmed delivery when the current copy policy requests it.
|
||||
/// Failures and unacknowledged terminal writes retain the selection.
|
||||
pub(crate) fn copy_selected_text_with(
|
||||
&mut self,
|
||||
cells: &[Arc<dyn HistoryCell>],
|
||||
@@ -396,8 +396,9 @@ impl TranscriptView {
|
||||
}
|
||||
ViewAction::Changed | ViewAction::OpenLink(_) => return None,
|
||||
};
|
||||
let clear_selection = !matches!(action, ViewAction::CopyOnSelect(_));
|
||||
let publish_primary = !clear_selection && self.primary_selection;
|
||||
let selection_copy = self.selection_copy(action);
|
||||
let clear_selection = selection_copy.clear_selection();
|
||||
let publish_primary = selection_copy.publishes_primary() && self.primary_selection;
|
||||
let mut primary_owner = None;
|
||||
let result =
|
||||
self.copy_selected_text_with(cells, text, clear_selection, |rich, rich_format| {
|
||||
|
||||
Reference in New Issue
Block a user