mirror of
https://github.com/openai/codex.git
synced 2026-11-19 22:30:42 +00:00
Allow disabling the in-process code-mode host fallback (#35266)
## What changed - Allow `features.code_mode_host` to use a configuration table with `disable_in_process_fallback`. When enabled, failure to start the standalone host is returned as tool output instead of falling back to embedded V8. - Preserve the existing fallback behavior by default and continue accepting the boolean feature toggle. - Limit displayed host paths in spawn errors to 512 bytes while retaining the executable-bearing suffix and valid UTF-8 boundaries. ## Testing - Cover boolean and table-based feature configuration, fallback-disabled host failures, and bounded ASCII and UTF-8 error paths. GitOrigin-RevId: ab3d014e79054c2f8beef9a658915f01cca197b2
This commit is contained in:
committed by
copyberry
parent
a453588416
commit
cba0e2701c
@@ -58,6 +58,10 @@ mod transport;
|
||||
const IPC_CHANNEL_CAPACITY: usize = 128;
|
||||
const HOST_HANDSHAKE_TIMEOUT: Duration = Duration::from_secs(10);
|
||||
const MAX_WEBSOCKET_FRAME_BYTES: usize = MAX_FRAME_BYTES + std::mem::size_of::<u32>();
|
||||
// Host spawn errors become model-visible tool output. Bound configured paths
|
||||
// while preserving the executable-bearing suffix needed to diagnose failures.
|
||||
const MAX_DISPLAYED_HOST_PROGRAM_BYTES: usize = 512;
|
||||
const TRUNCATED_HOST_PROGRAM_PREFIX: &str = "...";
|
||||
|
||||
pub(super) enum ConnectionError {
|
||||
Spawn {
|
||||
@@ -82,11 +86,27 @@ impl fmt::Display for ConnectionError {
|
||||
Self::Spawn {
|
||||
host_program,
|
||||
error,
|
||||
} => write!(
|
||||
formatter,
|
||||
"failed to spawn code-mode host {}: {error}",
|
||||
host_program.display()
|
||||
),
|
||||
} => {
|
||||
let host_program = host_program.to_string_lossy();
|
||||
if host_program.len() <= MAX_DISPLAYED_HOST_PROGRAM_BYTES {
|
||||
return write!(
|
||||
formatter,
|
||||
"failed to spawn code-mode host {host_program}: {error}"
|
||||
);
|
||||
}
|
||||
|
||||
let mut suffix_start = host_program.len()
|
||||
- (MAX_DISPLAYED_HOST_PROGRAM_BYTES - TRUNCATED_HOST_PROGRAM_PREFIX.len());
|
||||
while !host_program.is_char_boundary(suffix_start) {
|
||||
suffix_start += 1;
|
||||
}
|
||||
|
||||
write!(
|
||||
formatter,
|
||||
"failed to spawn code-mode host {TRUNCATED_HOST_PROGRAM_PREFIX}{}: {error}",
|
||||
&host_program[suffix_start..]
|
||||
)
|
||||
}
|
||||
Self::Other(message) => formatter.write_str(message),
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user