exec-server: test process id cleanup after spawn failure (#28130)

This commit is contained in:
Adam Perry
2026-06-16 22:26:08 +00:00
parent 5fa80a16ec
commit ca1db1403d
@@ -853,6 +853,73 @@ async fn exec_process_rejects_non_native_cwd_without_reserving_process_id(
Ok(())
}
#[test_case(false ; "local")]
#[test_case(true ; "remote")]
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
// Serialize tests that launch a real exec-server process through the full CLI.
#[serial_test::serial(remote_exec_server)]
async fn exec_process_reuses_id_after_spawn_failure(use_remote: bool) -> Result<()> {
let context = create_process_context(use_remote).await?;
let process_id = ProcessId::from("proc-spawn-failure");
let cwd = PathUri::from_path(std::env::current_dir()?)?;
let missing_executable = if cfg!(windows) {
r"C:\codex-exec-server-test\definitely-missing.exe"
} else {
"/codex-exec-server-test/definitely-missing"
};
let error = match context
.backend
.start(ExecParams {
process_id: process_id.clone(),
argv: vec![missing_executable.to_string()],
cwd: cwd.clone(),
env_policy: /*env_policy*/ None,
env: Default::default(),
tty: false,
pipe_stdin: false,
arg0: None,
})
.await
{
Ok(_) => anyhow::bail!("missing executable should fail during process launch"),
Err(error) => error,
};
let ExecServerError::Server { code, .. } = error else {
anyhow::bail!("unexpected process launch error: {error}");
};
assert_eq!(code, -32603);
let success_argv = if cfg!(windows) {
vec![
"cmd.exe".to_string(),
"/D".to_string(),
"/C".to_string(),
"exit 0".to_string(),
]
} else {
vec!["true".to_string()]
};
let session = context
.backend
.start(ExecParams {
process_id,
argv: success_argv,
cwd,
env_policy: /*env_policy*/ None,
env: Default::default(),
tty: false,
pipe_stdin: false,
arg0: None,
})
.await?;
let wake_rx = session.process.subscribe_wake();
assert_eq!(
collect_process_output_from_reads(session.process, wake_rx).await?,
(String::new(), Some(0), true)
);
Ok(())
}
#[test_case(false ; "local")]
#[test_case(true ; "remote")]
#[cfg_attr(not(unix), ignore = "Unix-only exec-server process test")]