From c959b049aec5fad405ae5e8914009cb041974792 Mon Sep 17 00:00:00 2001 From: Abhinav Vedmala Date: Thu, 30 Apr 2026 15:35:29 -0700 Subject: [PATCH] Restore base hooks browser guidance --- codex-rs/tui/src/bottom_pane/hooks_browser_view.rs | 6 +++++- ...r_view__tests__hooks_browser_capped_command_details.snap | 1 + ...s_browser_view__tests__hooks_browser_empty_handlers.snap | 1 + ...__hooks_browser_view__tests__hooks_browser_handlers.snap | 1 + ..._browser_view__tests__hooks_browser_managed_handler.snap | 1 + ...rowser_view__tests__hooks_browser_scrolled_handlers.snap | 1 + ...view__tests__hooks_browser_selected_managed_handler.snap | 1 + 7 files changed, 11 insertions(+), 1 deletion(-) diff --git a/codex-rs/tui/src/bottom_pane/hooks_browser_view.rs b/codex-rs/tui/src/bottom_pane/hooks_browser_view.rs index 26e762e3b5..84f47d1078 100644 --- a/codex-rs/tui/src/bottom_pane/hooks_browser_view.rs +++ b/codex-rs/tui/src/bottom_pane/hooks_browser_view.rs @@ -247,7 +247,11 @@ impl HooksBrowserView { ) -> Vec> { let mut lines = vec![format!("{} hooks", event_label(event_name)).bold().into()]; match review_needed_count { - 0 => {} + 0 => lines.push( + "Turn hooks on or off. Your changes are saved automatically." + .dim() + .into(), + ), 1 => lines.push("1 hook needs review before it can run.".dim().into()), count => lines.push( format!("{count} hooks need review before they can run.") diff --git a/codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__hooks_browser_view__tests__hooks_browser_capped_command_details.snap b/codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__hooks_browser_view__tests__hooks_browser_capped_command_details.snap index a747e50f2b..808b9dedbf 100644 --- a/codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__hooks_browser_view__tests__hooks_browser_capped_command_details.snap +++ b/codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__hooks_browser_view__tests__hooks_browser_capped_command_details.snap @@ -4,6 +4,7 @@ expression: "render_lines(&view, 44)" --- PreToolUse hooks + Turn hooks on or off. Your changes are s [x] Hook 1 diff --git a/codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__hooks_browser_view__tests__hooks_browser_empty_handlers.snap b/codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__hooks_browser_view__tests__hooks_browser_empty_handlers.snap index e65f953553..33321eec2b 100644 --- a/codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__hooks_browser_view__tests__hooks_browser_empty_handlers.snap +++ b/codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__hooks_browser_view__tests__hooks_browser_empty_handlers.snap @@ -4,6 +4,7 @@ expression: "render_lines(&view, 112)" --- PermissionRequest hooks + Turn hooks on or off. Your changes are saved automatically. No hooks installed for this event. diff --git a/codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__hooks_browser_view__tests__hooks_browser_handlers.snap b/codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__hooks_browser_view__tests__hooks_browser_handlers.snap index 62890612da..6e88734980 100644 --- a/codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__hooks_browser_view__tests__hooks_browser_handlers.snap +++ b/codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__hooks_browser_view__tests__hooks_browser_handlers.snap @@ -4,6 +4,7 @@ expression: "render_lines(&view, 112)" --- PreToolUse hooks + Turn hooks on or off. Your changes are saved automatically. [x] Hook 1 [ ] Hook 2 diff --git a/codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__hooks_browser_view__tests__hooks_browser_managed_handler.snap b/codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__hooks_browser_view__tests__hooks_browser_managed_handler.snap index 39ed8a6cda..d073b11b3c 100644 --- a/codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__hooks_browser_view__tests__hooks_browser_managed_handler.snap +++ b/codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__hooks_browser_view__tests__hooks_browser_managed_handler.snap @@ -4,6 +4,7 @@ expression: "render_lines(&view, 112)" --- PermissionRequest hooks + Turn hooks on or off. Your changes are saved automatically. [x] Hook 1 diff --git a/codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__hooks_browser_view__tests__hooks_browser_scrolled_handlers.snap b/codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__hooks_browser_view__tests__hooks_browser_scrolled_handlers.snap index c4d42319da..efeb0b2405 100644 --- a/codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__hooks_browser_view__tests__hooks_browser_scrolled_handlers.snap +++ b/codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__hooks_browser_view__tests__hooks_browser_scrolled_handlers.snap @@ -4,6 +4,7 @@ expression: "render_lines(&view, 112)" --- PreToolUse hooks + Turn hooks on or off. Your changes are saved automatically. [x] Hook 2 [x] Hook 3 diff --git a/codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__hooks_browser_view__tests__hooks_browser_selected_managed_handler.snap b/codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__hooks_browser_view__tests__hooks_browser_selected_managed_handler.snap index ac23f90ff6..514a8917a4 100644 --- a/codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__hooks_browser_view__tests__hooks_browser_selected_managed_handler.snap +++ b/codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__hooks_browser_view__tests__hooks_browser_selected_managed_handler.snap @@ -4,6 +4,7 @@ expression: "render_lines(&view, 112)" --- PreToolUse hooks + Turn hooks on or off. Your changes are saved automatically. [x] Hook 1 [x] Hook 2