mirror of
https://github.com/openai/codex.git
synced 2026-11-18 22:20:48 +00:00
Include environment hooks in thread hook listings (#56553)
## Why Listing hooks by working directory alone omits hooks supplied by a thread's selected execution environments, including hooks that can block a turn. ## What changed - Add `threadId` to `hooks/list` to return a loaded thread's current hook inventory, including selected, ready environments. Reject requests that also specify `cwds`. - Expose `environmentId` in hook metadata and have the TUI hooks browser query the current thread and label environment-owned hooks. Keep working-directory lookup for startup review. - Represent environment hook source paths with `PathUri` and use `LegacyAppPathString` in hook run summaries to preserve native path conventions. ## Testing Add coverage for listing a blocking environment hook and removing it after environment failure, delivering prompt input and reporting exit status in PowerShell and Bash, and running `PreToolUse` hooks only on the command's owning executor. Extend remote network tests to verify that environment hooks use the command's network policy while retaining their filesystem access. GitOrigin-RevId: 97229e22793df51f4bd502c1f9e19f0c52fb2305
This commit is contained in:
@@ -1403,7 +1403,7 @@ mod tests {
|
||||
execution_mode: HookExecutionMode::Sync,
|
||||
builtin: false,
|
||||
scope: HookScope::Turn,
|
||||
source_path: test_path_buf("/tmp/hooks.json").abs(),
|
||||
source_path: test_path_buf("/tmp/hooks.json").abs().into(),
|
||||
source,
|
||||
display_order: 0,
|
||||
status,
|
||||
|
||||
Reference in New Issue
Block a user