Add exec approval profile persistence core support

Co-authored-by: Codex <noreply@openai.com>
This commit is contained in:
Dylan Hurd
2026-03-22 14:35:19 -07:00
co-authored by Codex
parent 993274057e
commit c3df4c6a0a
17 changed files with 101 additions and 3 deletions
+14 -1
View File
@@ -10,6 +10,7 @@ use crate::permissions::NetworkSandboxPolicy;
use crate::protocol::FileChange;
use crate::protocol::ReviewDecision;
use crate::protocol::SandboxPolicy;
use crate::request_permissions::PermissionProfilePersistence;
use schemars::JsonSchema;
use serde::Deserialize;
use serde::Serialize;
@@ -181,6 +182,11 @@ pub struct ExecApprovalRequestEvent {
#[serde(default, skip_serializing_if = "Option::is_none")]
#[ts(optional)]
pub additional_permissions: Option<PermissionProfile>,
/// Optional named permissions profile that can absorb the requested
/// filesystem permissions for future approvals.
#[serde(default, skip_serializing_if = "Option::is_none")]
#[ts(optional)]
pub permissions_profile_persistence: Option<PermissionProfilePersistence>,
/// Optional skill metadata when the approval was triggered by a skill script.
#[serde(default, skip_serializing_if = "Option::is_none")]
#[ts(optional)]
@@ -212,6 +218,7 @@ impl ExecApprovalRequestEvent {
self.proposed_execpolicy_amendment.as_ref(),
self.proposed_network_policy_amendments.as_deref(),
self.additional_permissions.as_ref(),
self.permissions_profile_persistence.as_ref(),
),
}
}
@@ -221,6 +228,7 @@ impl ExecApprovalRequestEvent {
proposed_execpolicy_amendment: Option<&ExecPolicyAmendment>,
proposed_network_policy_amendments: Option<&[NetworkPolicyAmendment]>,
additional_permissions: Option<&PermissionProfile>,
permissions_profile_persistence: Option<&PermissionProfilePersistence>,
) -> Vec<ReviewDecision> {
if network_approval_context.is_some() {
let mut decisions = vec![ReviewDecision::Approved, ReviewDecision::ApprovedForSession];
@@ -238,7 +246,12 @@ impl ExecApprovalRequestEvent {
}
if additional_permissions.is_some() {
return vec![ReviewDecision::Approved, ReviewDecision::Abort];
let mut decisions = vec![ReviewDecision::Approved];
if permissions_profile_persistence.is_some() {
decisions.push(ReviewDecision::ApprovedPersistToProfile);
}
decisions.push(ReviewDecision::Abort);
return decisions;
}
let mut decisions = vec![ReviewDecision::Approved];
+8
View File
@@ -362,6 +362,9 @@ pub enum Op {
turn_id: Option<String>,
/// The user's decision in response to the request.
decision: ReviewDecision,
/// Optional permission-profile mutation to persist alongside approval.
#[serde(default, skip_serializing_if = "Option::is_none")]
persist_permissions: Option<PersistPermissionProfileAction>,
},
/// Approve a code patch
@@ -3178,6 +3181,10 @@ pub enum ReviewDecision {
/// remainder of the session.
ApprovedForSession,
/// User has approved this request and wants the filesystem permissions to
/// be persisted into the active named permissions profile.
ApprovedPersistToProfile,
/// User chose to persist a network policy rule (allow/deny) for future
/// requests to the same host.
NetworkPolicyAmendment {
@@ -3202,6 +3209,7 @@ impl ReviewDecision {
ReviewDecision::Approved => "approved",
ReviewDecision::ApprovedExecpolicyAmendment { .. } => "approved_with_amendment",
ReviewDecision::ApprovedForSession => "approved_for_session",
ReviewDecision::ApprovedPersistToProfile => "approved_persist_to_profile",
ReviewDecision::NetworkPolicyAmendment {
network_policy_amendment,
} => match network_policy_amendment.action {