mirror of
https://github.com/openai/codex.git
synced 2026-11-18 22:20:48 +00:00
Preserve pending realtime speech when a call ends (#62299)
## Why A realtime call can end with completed speech that has yet to reach a Codex turn. The next turn needs that context even if the call's transport has already disconnected. ## What changed - For V3 calls with realtime frame history enabled, save pending speech as context for the next turn. Restore it on thread reload and exclude it from the turn count used by rollback. - Drain already received transcript events and settle pending handoffs before saving the call's closing marker. Report recovery required if shutdown cannot confirm that history was saved. - Keep transport detach separate from ending a call. Reattaching restores saved pending speech, and an open call can be ended from persisted history after a reload. Use the call ID for TUI attachments so successive calls on one thread have distinct history. ## Testing Add coverage for queued speech at hangup, reconnect and stop after reload, retries after an uncertain write, and rollback across saved session-end context. GitOrigin-RevId: 657491f1d7e446a1a48e22189758810c8bdd82cb
This commit is contained in:
@@ -789,7 +789,13 @@ pub enum Op {
|
||||
/// Close the running realtime conversation stream.
|
||||
RealtimeConversationClose,
|
||||
|
||||
/// Close only the matching session after earlier start operations finish.
|
||||
/// End the identified logical call, including after its transport owner is lost.
|
||||
RealtimeConversationEnd {
|
||||
realtime_session_id: String,
|
||||
reply: oneshot::Sender<CodexResult<()>>,
|
||||
},
|
||||
|
||||
/// Disconnect only the matching transport after earlier start operations finish.
|
||||
RealtimeConversationDetach {
|
||||
realtime_session_id: String,
|
||||
reply: oneshot::Sender<CodexResult<()>>,
|
||||
@@ -1151,6 +1157,7 @@ impl Op {
|
||||
Self::RealtimeConversationText(_) => "realtime_conversation_text",
|
||||
Self::RealtimeConversationSpeech(_) => "realtime_conversation_speech",
|
||||
Self::RealtimeConversationClose => "realtime_conversation_close",
|
||||
Self::RealtimeConversationEnd { .. } => "realtime_conversation_end",
|
||||
Self::RealtimeConversationDetach { .. } => "realtime_conversation_detach",
|
||||
Self::RealtimeConversationListVoices => "realtime_conversation_list_voices",
|
||||
Self::RecoverTurn { .. } => "recover_turn",
|
||||
|
||||
Reference in New Issue
Block a user