mirror of
https://github.com/openai/codex.git
synced 2026-11-15 21:50:46 +00:00
Add independent controls for TUI visual effects (#46832)
## What changed Replace `tui.whimsy` with `[tui.effects]` preferences for `starfield`, `shimmer`, `welcome`, `effort`, `progress`, and `title`. Each defaults to `true` and remains subordinate to the `tui.animations` master switch. Wire the preferences into composer effects, welcome artwork, status and loading text, progress indicators, and terminal-title animations. For example, disable shimmering text while keeping progress animations: ```toml [tui.effects] shimmer = false ``` Keep retired `tui.whimsy` entries loadable but ignore their value. Update the configuration schema to expose the new preferences. ## Testing Add and extend coverage for independent shimmer and progress effects, master-switch precedence, welcome and starfield controls, terminal-title blinking, and strict configuration loading with the retired setting. GitOrigin-RevId: 28b37ba52872133b8954543cabe9ff424147f1c5
This commit is contained in:
@@ -343,7 +343,7 @@ impl ChatWidget {
|
||||
view_id: Some(PLUGINS_SELECTION_VIEW_ID),
|
||||
header: Box::new(DelayedLoadingHeader::new(
|
||||
self.frame_requester.clone(),
|
||||
self.local_settings.tui.animations,
|
||||
self.local_settings.tui.animations && self.local_settings.tui.effects.shimmer,
|
||||
"Loading available plugins...".to_string(),
|
||||
Some("This updates when the marketplace list is ready.".to_string()),
|
||||
)),
|
||||
@@ -362,7 +362,7 @@ impl ChatWidget {
|
||||
view_id: Some(PLUGINS_SELECTION_VIEW_ID),
|
||||
header: Box::new(DelayedLoadingHeader::new(
|
||||
self.frame_requester.clone(),
|
||||
self.local_settings.tui.animations,
|
||||
self.local_settings.tui.animations && self.local_settings.tui.effects.shimmer,
|
||||
"Adding marketplace...".to_string(),
|
||||
/*note*/ None,
|
||||
)),
|
||||
@@ -480,7 +480,7 @@ impl ChatWidget {
|
||||
view_id: Some(PLUGINS_SELECTION_VIEW_ID),
|
||||
header: Box::new(DelayedLoadingHeader::new(
|
||||
self.frame_requester.clone(),
|
||||
self.local_settings.tui.animations,
|
||||
self.local_settings.tui.animations && self.local_settings.tui.effects.shimmer,
|
||||
loading_text.clone(),
|
||||
/*note*/ None,
|
||||
)),
|
||||
@@ -502,7 +502,7 @@ impl ChatWidget {
|
||||
view_id: Some(PLUGINS_SELECTION_VIEW_ID),
|
||||
header: Box::new(DelayedLoadingHeader::new(
|
||||
self.frame_requester.clone(),
|
||||
self.local_settings.tui.animations,
|
||||
self.local_settings.tui.animations && self.local_settings.tui.effects.shimmer,
|
||||
format!("Loading details for {plugin_display_name}..."),
|
||||
/*note*/ None,
|
||||
)),
|
||||
|
||||
Reference in New Issue
Block a user