From b6791c8aea828fe733528e533a743415c81a8a99 Mon Sep 17 00:00:00 2001 From: Michael Bolin Date: Tue, 23 Jun 2026 17:05:44 -0700 Subject: [PATCH] chore: ResponseItem::AgentMessage should be assigned an id with `amsg_` prefix --- codex-rs/core/src/session/mod.rs | 5 ++--- codex-rs/core/src/session/tests.rs | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/codex-rs/core/src/session/mod.rs b/codex-rs/core/src/session/mod.rs index d94ca7f343..41b53b3fc4 100644 --- a/codex-rs/core/src/session/mod.rs +++ b/codex-rs/core/src/session/mod.rs @@ -2738,9 +2738,8 @@ impl Session { ResponseItem::WebSearchCall { .. } => "ws", ResponseItem::ImageGenerationCall { .. } => "ig", ResponseItem::Compaction { .. } | ResponseItem::ContextCompaction { .. } => "cmp", - ResponseItem::AgentMessage { .. } - | ResponseItem::CompactionTrigger { .. } - | ResponseItem::Other => continue, + ResponseItem::AgentMessage { .. } => "amsg", + ResponseItem::CompactionTrigger { .. } | ResponseItem::Other => continue, }; item.set_id(Some(format!("{prefix}_{}", Uuid::now_v7()))); } diff --git a/codex-rs/core/src/session/tests.rs b/codex-rs/core/src/session/tests.rs index 1ebb069f0f..9398431af7 100644 --- a/codex-rs/core/src/session/tests.rs +++ b/codex-rs/core/src/session/tests.rs @@ -210,7 +210,7 @@ fn user_message(text: &str) -> ResponseItem { } #[test] -fn assign_missing_response_item_ids_skips_agent_messages() { +fn assign_missing_response_item_ids_assigns_agent_message_ids() { let items = Cow::Owned(vec![ ResponseItem::AgentMessage { id: None, @@ -226,7 +226,7 @@ fn assign_missing_response_item_ids_skips_agent_messages() { let items = Session::assign_missing_response_item_ids(items); - assert_eq!(items[0].id(), None); + assert!(items[0].id().is_some_and(|id| id.starts_with("amsg_"))); assert!(items[1].id().is_some_and(|id| id.starts_with("msg_"))); }