From b61c1fc544dbb60920e5018526c75378299d6e28 Mon Sep 17 00:00:00 2001 From: Charles Cunningham Date: Fri, 20 Mar 2026 17:19:54 -0700 Subject: [PATCH] Relax guardian approval review wording Remove the 'This shape is expected to change soon.' wording from the long-lived guardian approval review payload docs while keeping the API marked unstable. Regenerate the app-server protocol schema fixtures to match. Co-authored-by: Codex --- .../app-server-protocol/schema/json/ServerNotification.json | 6 +++--- .../schema/json/codex_app_server_protocol.schemas.json | 6 +++--- .../schema/json/codex_app_server_protocol.v2.schemas.json | 6 +++--- ...xecutionGuardianApprovalReviewCompletedNotification.json | 2 +- ...dExecutionGuardianApprovalReviewStartedNotification.json | 2 +- ...leChangeGuardianApprovalReviewCompletedNotification.json | 2 +- ...FileChangeGuardianApprovalReviewStartedNotification.json | 2 +- .../v2/ItemGuardianApprovalReviewCompletedNotification.json | 4 ++-- .../v2/ItemGuardianApprovalReviewStartedNotification.json | 4 ++-- ...ToolCallGuardianApprovalReviewCompletedNotification.json | 2 +- ...cpToolCallGuardianApprovalReviewStartedNotification.json | 2 +- .../schema/typescript/v2/GuardianApprovalReview.ts | 2 +- .../v2/ItemGuardianApprovalReviewCompletedNotification.ts | 2 +- .../v2/ItemGuardianApprovalReviewStartedNotification.ts | 2 +- codex-rs/app-server-protocol/src/protocol/v2.rs | 6 +++--- 15 files changed, 25 insertions(+), 25 deletions(-) diff --git a/codex-rs/app-server-protocol/schema/json/ServerNotification.json b/codex-rs/app-server-protocol/schema/json/ServerNotification.json index 0b221a1e19..eaaeb022d1 100644 --- a/codex-rs/app-server-protocol/schema/json/ServerNotification.json +++ b/codex-rs/app-server-protocol/schema/json/ServerNotification.json @@ -1181,7 +1181,7 @@ "type": "object" }, "GuardianApprovalReview": { - "description": "[UNSTABLE] Temporary guardian approval review payload used by guardian approval review notifications. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary guardian approval review payload used by guardian approval review notifications.", "properties": { "rationale": { "type": [ @@ -1449,7 +1449,7 @@ "type": "object" }, "ItemGuardianApprovalReviewCompletedNotification": { - "description": "Deprecated: Use the parent item-specific `item/*/guardianApprovalReview/*` notifications instead.\n\n[UNSTABLE] Temporary notification payload for guardian automatic approval review. This shape is expected to change soon.\n\nTODO(ccunningham): Attach guardian review state to the reviewed tool item's lifecycle instead of sending separate standalone review notifications so the app-server API can persist and replay review state via `thread/read`.", + "description": "Deprecated: Use the parent item-specific `item/*/guardianApprovalReview/*` notifications instead.\n\n[UNSTABLE] Temporary notification payload for guardian automatic approval review.\n\nTODO(ccunningham): Attach guardian review state to the reviewed tool item's lifecycle instead of sending separate standalone review notifications so the app-server API can persist and replay review state via `thread/read`.", "properties": { "action": true, "review": { @@ -1474,7 +1474,7 @@ "type": "object" }, "ItemGuardianApprovalReviewStartedNotification": { - "description": "Deprecated: Use the parent item-specific `item/*/guardianApprovalReview/*` notifications instead.\n\n[UNSTABLE] Temporary notification payload for guardian automatic approval review. This shape is expected to change soon.\n\nTODO(ccunningham): Attach guardian review state to the reviewed tool item's lifecycle instead of sending separate standalone review notifications so the app-server API can persist and replay review state via `thread/read`.", + "description": "Deprecated: Use the parent item-specific `item/*/guardianApprovalReview/*` notifications instead.\n\n[UNSTABLE] Temporary notification payload for guardian automatic approval review.\n\nTODO(ccunningham): Attach guardian review state to the reviewed tool item's lifecycle instead of sending separate standalone review notifications so the app-server API can persist and replay review state via `thread/read`.", "properties": { "action": true, "review": { diff --git a/codex-rs/app-server-protocol/schema/json/codex_app_server_protocol.schemas.json b/codex-rs/app-server-protocol/schema/json/codex_app_server_protocol.schemas.json index dbcfcb78dc..ee646d7026 100644 --- a/codex-rs/app-server-protocol/schema/json/codex_app_server_protocol.schemas.json +++ b/codex-rs/app-server-protocol/schema/json/codex_app_server_protocol.schemas.json @@ -8123,7 +8123,7 @@ "type": "object" }, "GuardianApprovalReview": { - "description": "[UNSTABLE] Temporary guardian approval review payload used by guardian approval review notifications. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary guardian approval review payload used by guardian approval review notifications.", "properties": { "rationale": { "type": [ @@ -8426,7 +8426,7 @@ }, "ItemGuardianApprovalReviewCompletedNotification": { "$schema": "http://json-schema.org/draft-07/schema#", - "description": "Deprecated: Use the parent item-specific `item/*/guardianApprovalReview/*` notifications instead.\n\n[UNSTABLE] Temporary notification payload for guardian automatic approval review. This shape is expected to change soon.\n\nTODO(ccunningham): Attach guardian review state to the reviewed tool item's lifecycle instead of sending separate standalone review notifications so the app-server API can persist and replay review state via `thread/read`.", + "description": "Deprecated: Use the parent item-specific `item/*/guardianApprovalReview/*` notifications instead.\n\n[UNSTABLE] Temporary notification payload for guardian automatic approval review.\n\nTODO(ccunningham): Attach guardian review state to the reviewed tool item's lifecycle instead of sending separate standalone review notifications so the app-server API can persist and replay review state via `thread/read`.", "properties": { "action": true, "review": { @@ -8453,7 +8453,7 @@ }, "ItemGuardianApprovalReviewStartedNotification": { "$schema": "http://json-schema.org/draft-07/schema#", - "description": "Deprecated: Use the parent item-specific `item/*/guardianApprovalReview/*` notifications instead.\n\n[UNSTABLE] Temporary notification payload for guardian automatic approval review. This shape is expected to change soon.\n\nTODO(ccunningham): Attach guardian review state to the reviewed tool item's lifecycle instead of sending separate standalone review notifications so the app-server API can persist and replay review state via `thread/read`.", + "description": "Deprecated: Use the parent item-specific `item/*/guardianApprovalReview/*` notifications instead.\n\n[UNSTABLE] Temporary notification payload for guardian automatic approval review.\n\nTODO(ccunningham): Attach guardian review state to the reviewed tool item's lifecycle instead of sending separate standalone review notifications so the app-server API can persist and replay review state via `thread/read`.", "properties": { "action": true, "review": { diff --git a/codex-rs/app-server-protocol/schema/json/codex_app_server_protocol.v2.schemas.json b/codex-rs/app-server-protocol/schema/json/codex_app_server_protocol.v2.schemas.json index c67c370712..dcd5fea481 100644 --- a/codex-rs/app-server-protocol/schema/json/codex_app_server_protocol.v2.schemas.json +++ b/codex-rs/app-server-protocol/schema/json/codex_app_server_protocol.v2.schemas.json @@ -4705,7 +4705,7 @@ "type": "object" }, "GuardianApprovalReview": { - "description": "[UNSTABLE] Temporary guardian approval review payload used by guardian approval review notifications. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary guardian approval review payload used by guardian approval review notifications.", "properties": { "rationale": { "type": [ @@ -5052,7 +5052,7 @@ }, "ItemGuardianApprovalReviewCompletedNotification": { "$schema": "http://json-schema.org/draft-07/schema#", - "description": "Deprecated: Use the parent item-specific `item/*/guardianApprovalReview/*` notifications instead.\n\n[UNSTABLE] Temporary notification payload for guardian automatic approval review. This shape is expected to change soon.\n\nTODO(ccunningham): Attach guardian review state to the reviewed tool item's lifecycle instead of sending separate standalone review notifications so the app-server API can persist and replay review state via `thread/read`.", + "description": "Deprecated: Use the parent item-specific `item/*/guardianApprovalReview/*` notifications instead.\n\n[UNSTABLE] Temporary notification payload for guardian automatic approval review.\n\nTODO(ccunningham): Attach guardian review state to the reviewed tool item's lifecycle instead of sending separate standalone review notifications so the app-server API can persist and replay review state via `thread/read`.", "properties": { "action": true, "review": { @@ -5079,7 +5079,7 @@ }, "ItemGuardianApprovalReviewStartedNotification": { "$schema": "http://json-schema.org/draft-07/schema#", - "description": "Deprecated: Use the parent item-specific `item/*/guardianApprovalReview/*` notifications instead.\n\n[UNSTABLE] Temporary notification payload for guardian automatic approval review. This shape is expected to change soon.\n\nTODO(ccunningham): Attach guardian review state to the reviewed tool item's lifecycle instead of sending separate standalone review notifications so the app-server API can persist and replay review state via `thread/read`.", + "description": "Deprecated: Use the parent item-specific `item/*/guardianApprovalReview/*` notifications instead.\n\n[UNSTABLE] Temporary notification payload for guardian automatic approval review.\n\nTODO(ccunningham): Attach guardian review state to the reviewed tool item's lifecycle instead of sending separate standalone review notifications so the app-server API can persist and replay review state via `thread/read`.", "properties": { "action": true, "review": { diff --git a/codex-rs/app-server-protocol/schema/json/v2/CommandExecutionGuardianApprovalReviewCompletedNotification.json b/codex-rs/app-server-protocol/schema/json/v2/CommandExecutionGuardianApprovalReviewCompletedNotification.json index 113439d71c..79c25bcbd4 100644 --- a/codex-rs/app-server-protocol/schema/json/v2/CommandExecutionGuardianApprovalReviewCompletedNotification.json +++ b/codex-rs/app-server-protocol/schema/json/v2/CommandExecutionGuardianApprovalReviewCompletedNotification.json @@ -2,7 +2,7 @@ "$schema": "http://json-schema.org/draft-07/schema#", "definitions": { "GuardianApprovalReview": { - "description": "[UNSTABLE] Temporary guardian approval review payload used by guardian approval review notifications. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary guardian approval review payload used by guardian approval review notifications.", "properties": { "rationale": { "type": [ diff --git a/codex-rs/app-server-protocol/schema/json/v2/CommandExecutionGuardianApprovalReviewStartedNotification.json b/codex-rs/app-server-protocol/schema/json/v2/CommandExecutionGuardianApprovalReviewStartedNotification.json index e643e9ca85..d6fd35077a 100644 --- a/codex-rs/app-server-protocol/schema/json/v2/CommandExecutionGuardianApprovalReviewStartedNotification.json +++ b/codex-rs/app-server-protocol/schema/json/v2/CommandExecutionGuardianApprovalReviewStartedNotification.json @@ -2,7 +2,7 @@ "$schema": "http://json-schema.org/draft-07/schema#", "definitions": { "GuardianApprovalReview": { - "description": "[UNSTABLE] Temporary guardian approval review payload used by guardian approval review notifications. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary guardian approval review payload used by guardian approval review notifications.", "properties": { "rationale": { "type": [ diff --git a/codex-rs/app-server-protocol/schema/json/v2/FileChangeGuardianApprovalReviewCompletedNotification.json b/codex-rs/app-server-protocol/schema/json/v2/FileChangeGuardianApprovalReviewCompletedNotification.json index e796bcf539..d31c276b51 100644 --- a/codex-rs/app-server-protocol/schema/json/v2/FileChangeGuardianApprovalReviewCompletedNotification.json +++ b/codex-rs/app-server-protocol/schema/json/v2/FileChangeGuardianApprovalReviewCompletedNotification.json @@ -2,7 +2,7 @@ "$schema": "http://json-schema.org/draft-07/schema#", "definitions": { "GuardianApprovalReview": { - "description": "[UNSTABLE] Temporary guardian approval review payload used by guardian approval review notifications. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary guardian approval review payload used by guardian approval review notifications.", "properties": { "rationale": { "type": [ diff --git a/codex-rs/app-server-protocol/schema/json/v2/FileChangeGuardianApprovalReviewStartedNotification.json b/codex-rs/app-server-protocol/schema/json/v2/FileChangeGuardianApprovalReviewStartedNotification.json index 9f17b9ebe9..59ebfb6176 100644 --- a/codex-rs/app-server-protocol/schema/json/v2/FileChangeGuardianApprovalReviewStartedNotification.json +++ b/codex-rs/app-server-protocol/schema/json/v2/FileChangeGuardianApprovalReviewStartedNotification.json @@ -2,7 +2,7 @@ "$schema": "http://json-schema.org/draft-07/schema#", "definitions": { "GuardianApprovalReview": { - "description": "[UNSTABLE] Temporary guardian approval review payload used by guardian approval review notifications. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary guardian approval review payload used by guardian approval review notifications.", "properties": { "rationale": { "type": [ diff --git a/codex-rs/app-server-protocol/schema/json/v2/ItemGuardianApprovalReviewCompletedNotification.json b/codex-rs/app-server-protocol/schema/json/v2/ItemGuardianApprovalReviewCompletedNotification.json index ef7c93b73c..3fd801ef81 100644 --- a/codex-rs/app-server-protocol/schema/json/v2/ItemGuardianApprovalReviewCompletedNotification.json +++ b/codex-rs/app-server-protocol/schema/json/v2/ItemGuardianApprovalReviewCompletedNotification.json @@ -2,7 +2,7 @@ "$schema": "http://json-schema.org/draft-07/schema#", "definitions": { "GuardianApprovalReview": { - "description": "[UNSTABLE] Temporary guardian approval review payload used by guardian approval review notifications. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary guardian approval review payload used by guardian approval review notifications.", "properties": { "rationale": { "type": [ @@ -57,7 +57,7 @@ "type": "string" } }, - "description": "Deprecated: Use the parent item-specific `item/*/guardianApprovalReview/*` notifications instead.\n\n[UNSTABLE] Temporary notification payload for guardian automatic approval review. This shape is expected to change soon.\n\nTODO(ccunningham): Attach guardian review state to the reviewed tool item's lifecycle instead of sending separate standalone review notifications so the app-server API can persist and replay review state via `thread/read`.", + "description": "Deprecated: Use the parent item-specific `item/*/guardianApprovalReview/*` notifications instead.\n\n[UNSTABLE] Temporary notification payload for guardian automatic approval review.\n\nTODO(ccunningham): Attach guardian review state to the reviewed tool item's lifecycle instead of sending separate standalone review notifications so the app-server API can persist and replay review state via `thread/read`.", "properties": { "action": true, "review": { diff --git a/codex-rs/app-server-protocol/schema/json/v2/ItemGuardianApprovalReviewStartedNotification.json b/codex-rs/app-server-protocol/schema/json/v2/ItemGuardianApprovalReviewStartedNotification.json index 10558264fd..cb560b88c5 100644 --- a/codex-rs/app-server-protocol/schema/json/v2/ItemGuardianApprovalReviewStartedNotification.json +++ b/codex-rs/app-server-protocol/schema/json/v2/ItemGuardianApprovalReviewStartedNotification.json @@ -2,7 +2,7 @@ "$schema": "http://json-schema.org/draft-07/schema#", "definitions": { "GuardianApprovalReview": { - "description": "[UNSTABLE] Temporary guardian approval review payload used by guardian approval review notifications. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary guardian approval review payload used by guardian approval review notifications.", "properties": { "rationale": { "type": [ @@ -57,7 +57,7 @@ "type": "string" } }, - "description": "Deprecated: Use the parent item-specific `item/*/guardianApprovalReview/*` notifications instead.\n\n[UNSTABLE] Temporary notification payload for guardian automatic approval review. This shape is expected to change soon.\n\nTODO(ccunningham): Attach guardian review state to the reviewed tool item's lifecycle instead of sending separate standalone review notifications so the app-server API can persist and replay review state via `thread/read`.", + "description": "Deprecated: Use the parent item-specific `item/*/guardianApprovalReview/*` notifications instead.\n\n[UNSTABLE] Temporary notification payload for guardian automatic approval review.\n\nTODO(ccunningham): Attach guardian review state to the reviewed tool item's lifecycle instead of sending separate standalone review notifications so the app-server API can persist and replay review state via `thread/read`.", "properties": { "action": true, "review": { diff --git a/codex-rs/app-server-protocol/schema/json/v2/McpToolCallGuardianApprovalReviewCompletedNotification.json b/codex-rs/app-server-protocol/schema/json/v2/McpToolCallGuardianApprovalReviewCompletedNotification.json index a1aa8518c0..45847e1564 100644 --- a/codex-rs/app-server-protocol/schema/json/v2/McpToolCallGuardianApprovalReviewCompletedNotification.json +++ b/codex-rs/app-server-protocol/schema/json/v2/McpToolCallGuardianApprovalReviewCompletedNotification.json @@ -2,7 +2,7 @@ "$schema": "http://json-schema.org/draft-07/schema#", "definitions": { "GuardianApprovalReview": { - "description": "[UNSTABLE] Temporary guardian approval review payload used by guardian approval review notifications. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary guardian approval review payload used by guardian approval review notifications.", "properties": { "rationale": { "type": [ diff --git a/codex-rs/app-server-protocol/schema/json/v2/McpToolCallGuardianApprovalReviewStartedNotification.json b/codex-rs/app-server-protocol/schema/json/v2/McpToolCallGuardianApprovalReviewStartedNotification.json index 59234eed64..c32d63894b 100644 --- a/codex-rs/app-server-protocol/schema/json/v2/McpToolCallGuardianApprovalReviewStartedNotification.json +++ b/codex-rs/app-server-protocol/schema/json/v2/McpToolCallGuardianApprovalReviewStartedNotification.json @@ -2,7 +2,7 @@ "$schema": "http://json-schema.org/draft-07/schema#", "definitions": { "GuardianApprovalReview": { - "description": "[UNSTABLE] Temporary guardian approval review payload used by guardian approval review notifications. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary guardian approval review payload used by guardian approval review notifications.", "properties": { "rationale": { "type": [ diff --git a/codex-rs/app-server-protocol/schema/typescript/v2/GuardianApprovalReview.ts b/codex-rs/app-server-protocol/schema/typescript/v2/GuardianApprovalReview.ts index d5e7d11bcb..d5bf603484 100644 --- a/codex-rs/app-server-protocol/schema/typescript/v2/GuardianApprovalReview.ts +++ b/codex-rs/app-server-protocol/schema/typescript/v2/GuardianApprovalReview.ts @@ -6,6 +6,6 @@ import type { GuardianRiskLevel } from "./GuardianRiskLevel"; /** * [UNSTABLE] Temporary guardian approval review payload used by guardian - * approval review notifications. This shape is expected to change soon. + * approval review notifications. */ export type GuardianApprovalReview = { status: GuardianApprovalReviewStatus, riskScore: number | null, riskLevel: GuardianRiskLevel | null, rationale: string | null, }; diff --git a/codex-rs/app-server-protocol/schema/typescript/v2/ItemGuardianApprovalReviewCompletedNotification.ts b/codex-rs/app-server-protocol/schema/typescript/v2/ItemGuardianApprovalReviewCompletedNotification.ts index e7e310dfbf..aedba9e875 100644 --- a/codex-rs/app-server-protocol/schema/typescript/v2/ItemGuardianApprovalReviewCompletedNotification.ts +++ b/codex-rs/app-server-protocol/schema/typescript/v2/ItemGuardianApprovalReviewCompletedNotification.ts @@ -9,7 +9,7 @@ import type { GuardianApprovalReview } from "./GuardianApprovalReview"; * `item/*/guardianApprovalReview/*` notifications instead. * * [UNSTABLE] Temporary notification payload for guardian automatic approval - * review. This shape is expected to change soon. + * review. * * TODO(ccunningham): Attach guardian review state to the reviewed tool item's * lifecycle instead of sending separate standalone review notifications so the diff --git a/codex-rs/app-server-protocol/schema/typescript/v2/ItemGuardianApprovalReviewStartedNotification.ts b/codex-rs/app-server-protocol/schema/typescript/v2/ItemGuardianApprovalReviewStartedNotification.ts index 52abada59c..c03548b235 100644 --- a/codex-rs/app-server-protocol/schema/typescript/v2/ItemGuardianApprovalReviewStartedNotification.ts +++ b/codex-rs/app-server-protocol/schema/typescript/v2/ItemGuardianApprovalReviewStartedNotification.ts @@ -9,7 +9,7 @@ import type { GuardianApprovalReview } from "./GuardianApprovalReview"; * `item/*/guardianApprovalReview/*` notifications instead. * * [UNSTABLE] Temporary notification payload for guardian automatic approval - * review. This shape is expected to change soon. + * review. * * TODO(ccunningham): Attach guardian review state to the reviewed tool item's * lifecycle instead of sending separate standalone review notifications so the diff --git a/codex-rs/app-server-protocol/src/protocol/v2.rs b/codex-rs/app-server-protocol/src/protocol/v2.rs index d78cd0fc25..a9f2f72a1e 100644 --- a/codex-rs/app-server-protocol/src/protocol/v2.rs +++ b/codex-rs/app-server-protocol/src/protocol/v2.rs @@ -4345,7 +4345,7 @@ impl From for GuardianRiskLevel { } /// [UNSTABLE] Temporary guardian approval review payload used by guardian -/// approval review notifications. This shape is expected to change soon. +/// approval review notifications. #[derive(Serialize, Deserialize, Debug, Clone, PartialEq, Eq, JsonSchema, TS)] #[serde(rename_all = "camelCase")] #[ts(export_to = "v2/")] @@ -4910,7 +4910,7 @@ pub struct McpToolCallGuardianApprovalReviewCompletedNotification { /// `item/*/guardianApprovalReview/*` notifications instead. /// /// [UNSTABLE] Temporary notification payload for guardian automatic approval -/// review. This shape is expected to change soon. +/// review. /// /// TODO(ccunningham): Attach guardian review state to the reviewed tool item's /// lifecycle instead of sending separate standalone review notifications so the @@ -4930,7 +4930,7 @@ pub struct ItemGuardianApprovalReviewStartedNotification { /// `item/*/guardianApprovalReview/*` notifications instead. /// /// [UNSTABLE] Temporary notification payload for guardian automatic approval -/// review. This shape is expected to change soon. +/// review. /// /// TODO(ccunningham): Attach guardian review state to the reviewed tool item's /// lifecycle instead of sending separate standalone review notifications so the