mirror of
https://github.com/openai/codex.git
synced 2026-11-20 22:40:37 +00:00
Scope environment readiness config to thread attachments (#38067)
## Why Threads that share an executor environment can require different capability roots and login-shell policies. Treating readiness configuration as executor-wide can expose one thread's settings to another. ## What changed - Add `CodexThread::environment_ready` and `EnvironmentConfig` so hosts can install capability roots and login-shell policy for an exact thread, environment, and working-directory attachment. - Validate attachment readiness updates, merge ready attachment roots with persisted thread roots, and refresh MCP capabilities when those roots change. - Preserve installed environment policy across thread settings updates and child-thread inheritance while resetting it when the selected working directory changes. ## Testing - Cover attachment config inheritance and reset behavior. - Verify that threads sharing an executor retain independent model-visible capability roots and login-shell tool schemas across updates. GitOrigin-RevId: 60e7a296b3e41b835b0413aa2837451e8a55c230
This commit is contained in:
@@ -1,6 +1,7 @@
|
||||
use crate::agent::AgentStatus;
|
||||
use crate::config::ConstraintResult;
|
||||
use crate::elicitation::ElicitationRegistration;
|
||||
use crate::environment_config::EnvironmentConfig;
|
||||
use crate::session::SessionIo;
|
||||
use crate::session::SessionSettingsUpdate;
|
||||
use crate::session::SteerInputError;
|
||||
@@ -766,13 +767,18 @@ impl CodexThread {
|
||||
self.session.thread_environment_selections().await
|
||||
}
|
||||
|
||||
/// Installs resolved environment configuration and capability roots on this thread.
|
||||
pub async fn environment_ready(
|
||||
&self,
|
||||
selection: &TurnEnvironmentSelection,
|
||||
config: EnvironmentConfig,
|
||||
) -> CodexResult<()> {
|
||||
self.session.environment_ready(selection, config).await
|
||||
}
|
||||
|
||||
/// Passively inspects the selected capability roots whose environments are ready now.
|
||||
pub fn inspect_selected_capability_roots(&self) -> SelectedCapabilityRootsStatus {
|
||||
self.session
|
||||
.services
|
||||
.turn_environments
|
||||
.environment_manager()
|
||||
.inspect_selected_capability_roots(&self.session.services.selected_capability_roots)
|
||||
self.session.inspect_selected_capability_roots()
|
||||
}
|
||||
|
||||
pub async fn read_mcp_resource(
|
||||
|
||||
Reference in New Issue
Block a user