From b1d1c47e63eb8a751f43da5eeab1dec727a2512e Mon Sep 17 00:00:00 2001 From: Michael Bolin Date: Thu, 2 Apr 2026 12:21:24 -0700 Subject: [PATCH] fix: add more detail to test assertion --- codex-rs/core/tests/suite/user_shell_cmd.rs | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/codex-rs/core/tests/suite/user_shell_cmd.rs b/codex-rs/core/tests/suite/user_shell_cmd.rs index c0fe8b5352..f6abb5d621 100644 --- a/codex-rs/core/tests/suite/user_shell_cmd.rs +++ b/codex-rs/core/tests/suite/user_shell_cmd.rs @@ -350,13 +350,22 @@ async fn user_shell_command_does_not_set_network_sandbox_env_var() -> anyhow::Re .submit(Op::RunUserShellCommand { command }) .await?; - let end_event = wait_for_event_match(&test.codex, |ev| match ev { + let ExecCommandEndEvent { + exit_code, + stdout, + stderr, + .. + } = wait_for_event_match(&test.codex, |ev| match ev { EventMsg::ExecCommandEnd(event) => Some(event.clone()), _ => None, }) .await; - assert_eq!(end_event.exit_code, 0); - assert_eq!(end_event.stdout.trim(), "not-set"); + + assert_eq!( + exit_code, 0, + "shell command should execute successfully. stdout=`{stdout}`, stderr=`{stderr}`", + ); + assert_eq!(stdout.trim(), "not-set"); Ok(()) }