From afaad7cdc010c9e15827b7f108465c812fe65e91 Mon Sep 17 00:00:00 2001 From: vkg-oai Date: Mon, 14 Sep 2026 19:00:05 +0000 Subject: [PATCH] Trace global user instruction loading (#45496) ## What changed Add an `instructions.load` tracing span with `provider = "global"` around loading user instructions from the Codex home directory. Skip recording function arguments and add the `tracing` dependency to `codex-home`. GitOrigin-RevId: 1b11e4b18f7a0dbee742a092aba580a184dc5fbf --- codex-rs/Cargo.lock | 1 + codex-rs/codex-home/Cargo.toml | 1 + codex-rs/codex-home/src/instructions/mod.rs | 1 + 3 files changed, 3 insertions(+) diff --git a/codex-rs/Cargo.lock b/codex-rs/Cargo.lock index 417f19779b..60170140db 100644 --- a/codex-rs/Cargo.lock +++ b/codex-rs/Cargo.lock @@ -3658,6 +3658,7 @@ dependencies = [ "pretty_assertions", "tempfile", "tokio", + "tracing", ] [[package]] diff --git a/codex-rs/codex-home/Cargo.toml b/codex-rs/codex-home/Cargo.toml index a8fa625dcf..068ec55b4e 100644 --- a/codex-rs/codex-home/Cargo.toml +++ b/codex-rs/codex-home/Cargo.toml @@ -14,6 +14,7 @@ workspace = true codex-extension-api = { workspace = true } codex-utils-absolute-path = { workspace = true } tokio = { workspace = true, features = ["fs"] } +tracing = { workspace = true } [dev-dependencies] pretty_assertions = { workspace = true } diff --git a/codex-rs/codex-home/src/instructions/mod.rs b/codex-rs/codex-home/src/instructions/mod.rs index aa3a67267f..a16ad668af 100644 --- a/codex-rs/codex-home/src/instructions/mod.rs +++ b/codex-rs/codex-home/src/instructions/mod.rs @@ -37,6 +37,7 @@ impl CodexHomeUserInstructionsProvider { } } + #[tracing::instrument(name = "instructions.load", skip_all, fields(provider = "global"))] async fn load_from_codex_home(&self) -> LoadedUserInstructions { let mut warnings = Vec::new(); for candidate in [LOCAL_AGENTS_MD_FILENAME, DEFAULT_AGENTS_MD_FILENAME] {