From ae5a20f5857a71383b9e229220e0808421f4a7b2 Mon Sep 17 00:00:00 2001 From: dhruvgupta-oai Date: Mon, 23 Mar 2026 18:44:31 -0400 Subject: [PATCH] Make broken MCP startup tests deterministic --- .../app-server/tests/suite/v2/thread_start.rs | 20 +++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/codex-rs/app-server/tests/suite/v2/thread_start.rs b/codex-rs/app-server/tests/suite/v2/thread_start.rs index 37ca5a3903..103373654d 100644 --- a/codex-rs/app-server/tests/suite/v2/thread_start.rs +++ b/codex-rs/app-server/tests/suite/v2/thread_start.rs @@ -585,9 +585,11 @@ request_max_retries = 0 stream_max_retries = 0 [mcp_servers.required_broken] -command = "codex-definitely-not-a-real-binary" +{required_broken_transport} required = true "# + , + required_broken_transport = broken_mcp_transport_toml() ), ) } @@ -615,8 +617,22 @@ request_max_retries = 0 stream_max_retries = 0 [mcp_servers.optional_broken] -command = "codex-definitely-not-a-real-binary" +{optional_broken_transport} "# + , + optional_broken_transport = broken_mcp_transport_toml() ), ) } + +#[cfg(target_os = "windows")] +fn broken_mcp_transport_toml() -> &'static str { + r#"command = "cmd" +args = ["/C", "exit 1"]"# +} + +#[cfg(not(target_os = "windows"))] +fn broken_mcp_transport_toml() -> &'static str { + r#"command = "/bin/sh" +args = ["-c", "exit 1"]"# +}