From adcbd4549e420160fbcb552a2a74cbd4eba0a8ee Mon Sep 17 00:00:00 2001 From: Charles Cunningham Date: Fri, 20 Mar 2026 17:28:03 -0700 Subject: [PATCH] Remove guardian review change-soon wording Strip 'This shape is expected to change soon.' from the guardian approval review protocol docs and regenerated schema fixtures, while keeping the affected APIs marked unstable or deprecated as appropriate. Co-authored-by: Codex --- .../schema/json/ServerNotification.json | 12 ++++++------ .../json/codex_app_server_protocol.schemas.json | 12 ++++++------ .../json/codex_app_server_protocol.v2.schemas.json | 12 ++++++------ ...nGuardianApprovalReviewCompletedNotification.json | 2 +- ...ionGuardianApprovalReviewStartedNotification.json | 2 +- ...eGuardianApprovalReviewCompletedNotification.json | 2 +- ...ngeGuardianApprovalReviewStartedNotification.json | 2 +- ...lGuardianApprovalReviewCompletedNotification.json | 2 +- ...allGuardianApprovalReviewStartedNotification.json | 2 +- ...ionGuardianApprovalReviewCompletedNotification.ts | 2 +- ...utionGuardianApprovalReviewStartedNotification.ts | 2 +- ...ngeGuardianApprovalReviewCompletedNotification.ts | 2 +- ...hangeGuardianApprovalReviewStartedNotification.ts | 2 +- ...allGuardianApprovalReviewCompletedNotification.ts | 2 +- ...lCallGuardianApprovalReviewStartedNotification.ts | 2 +- codex-rs/app-server-protocol/src/protocol/v2.rs | 12 ++++++------ 16 files changed, 36 insertions(+), 36 deletions(-) diff --git a/codex-rs/app-server-protocol/schema/json/ServerNotification.json b/codex-rs/app-server-protocol/schema/json/ServerNotification.json index eaaeb022d1..fe121c0621 100644 --- a/codex-rs/app-server-protocol/schema/json/ServerNotification.json +++ b/codex-rs/app-server-protocol/schema/json/ServerNotification.json @@ -726,7 +726,7 @@ ] }, "CommandExecutionGuardianApprovalReviewCompletedNotification": { - "description": "[UNSTABLE] Temporary notification payload for guardian approval review on a command execution item. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary notification payload for guardian approval review on a command execution item.", "properties": { "action": true, "itemId": { @@ -751,7 +751,7 @@ "type": "object" }, "CommandExecutionGuardianApprovalReviewStartedNotification": { - "description": "[UNSTABLE] Temporary notification payload for guardian approval review on a command execution item. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary notification payload for guardian approval review on a command execution item.", "properties": { "action": true, "itemId": { @@ -985,7 +985,7 @@ "type": "object" }, "FileChangeGuardianApprovalReviewCompletedNotification": { - "description": "[UNSTABLE] Temporary notification payload for guardian approval review on a file change item. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary notification payload for guardian approval review on a file change item.", "properties": { "action": true, "itemId": { @@ -1010,7 +1010,7 @@ "type": "object" }, "FileChangeGuardianApprovalReviewStartedNotification": { - "description": "[UNSTABLE] Temporary notification payload for guardian approval review on a file change item. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary notification payload for guardian approval review on a file change item.", "properties": { "action": true, "itemId": { @@ -1580,7 +1580,7 @@ "type": "object" }, "McpToolCallGuardianApprovalReviewCompletedNotification": { - "description": "[UNSTABLE] Temporary notification payload for guardian approval review on an MCP tool call item. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary notification payload for guardian approval review on an MCP tool call item.", "properties": { "action": true, "itemId": { @@ -1605,7 +1605,7 @@ "type": "object" }, "McpToolCallGuardianApprovalReviewStartedNotification": { - "description": "[UNSTABLE] Temporary notification payload for guardian approval review on an MCP tool call item. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary notification payload for guardian approval review on an MCP tool call item.", "properties": { "action": true, "itemId": { diff --git a/codex-rs/app-server-protocol/schema/json/codex_app_server_protocol.schemas.json b/codex-rs/app-server-protocol/schema/json/codex_app_server_protocol.schemas.json index ee646d7026..14660d809f 100644 --- a/codex-rs/app-server-protocol/schema/json/codex_app_server_protocol.schemas.json +++ b/codex-rs/app-server-protocol/schema/json/codex_app_server_protocol.schemas.json @@ -6291,7 +6291,7 @@ }, "CommandExecutionGuardianApprovalReviewCompletedNotification": { "$schema": "http://json-schema.org/draft-07/schema#", - "description": "[UNSTABLE] Temporary notification payload for guardian approval review on a command execution item. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary notification payload for guardian approval review on a command execution item.", "properties": { "action": true, "itemId": { @@ -6318,7 +6318,7 @@ }, "CommandExecutionGuardianApprovalReviewStartedNotification": { "$schema": "http://json-schema.org/draft-07/schema#", - "description": "[UNSTABLE] Temporary notification payload for guardian approval review on a command execution item. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary notification payload for guardian approval review on a command execution item.", "properties": { "action": true, "itemId": { @@ -7549,7 +7549,7 @@ }, "FileChangeGuardianApprovalReviewCompletedNotification": { "$schema": "http://json-schema.org/draft-07/schema#", - "description": "[UNSTABLE] Temporary notification payload for guardian approval review on a file change item. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary notification payload for guardian approval review on a file change item.", "properties": { "action": true, "itemId": { @@ -7576,7 +7576,7 @@ }, "FileChangeGuardianApprovalReviewStartedNotification": { "$schema": "http://json-schema.org/draft-07/schema#", - "description": "[UNSTABLE] Temporary notification payload for guardian approval review on a file change item. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary notification payload for guardian approval review on a file change item.", "properties": { "action": true, "itemId": { @@ -8924,7 +8924,7 @@ }, "McpToolCallGuardianApprovalReviewCompletedNotification": { "$schema": "http://json-schema.org/draft-07/schema#", - "description": "[UNSTABLE] Temporary notification payload for guardian approval review on an MCP tool call item. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary notification payload for guardian approval review on an MCP tool call item.", "properties": { "action": true, "itemId": { @@ -8951,7 +8951,7 @@ }, "McpToolCallGuardianApprovalReviewStartedNotification": { "$schema": "http://json-schema.org/draft-07/schema#", - "description": "[UNSTABLE] Temporary notification payload for guardian approval review on an MCP tool call item. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary notification payload for guardian approval review on an MCP tool call item.", "properties": { "action": true, "itemId": { diff --git a/codex-rs/app-server-protocol/schema/json/codex_app_server_protocol.v2.schemas.json b/codex-rs/app-server-protocol/schema/json/codex_app_server_protocol.v2.schemas.json index dcd5fea481..ed9259dc6e 100644 --- a/codex-rs/app-server-protocol/schema/json/codex_app_server_protocol.v2.schemas.json +++ b/codex-rs/app-server-protocol/schema/json/codex_app_server_protocol.v2.schemas.json @@ -2762,7 +2762,7 @@ }, "CommandExecutionGuardianApprovalReviewCompletedNotification": { "$schema": "http://json-schema.org/draft-07/schema#", - "description": "[UNSTABLE] Temporary notification payload for guardian approval review on a command execution item. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary notification payload for guardian approval review on a command execution item.", "properties": { "action": true, "itemId": { @@ -2789,7 +2789,7 @@ }, "CommandExecutionGuardianApprovalReviewStartedNotification": { "$schema": "http://json-schema.org/draft-07/schema#", - "description": "[UNSTABLE] Temporary notification payload for guardian approval review on a command execution item. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary notification payload for guardian approval review on a command execution item.", "properties": { "action": true, "itemId": { @@ -4020,7 +4020,7 @@ }, "FileChangeGuardianApprovalReviewCompletedNotification": { "$schema": "http://json-schema.org/draft-07/schema#", - "description": "[UNSTABLE] Temporary notification payload for guardian approval review on a file change item. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary notification payload for guardian approval review on a file change item.", "properties": { "action": true, "itemId": { @@ -4047,7 +4047,7 @@ }, "FileChangeGuardianApprovalReviewStartedNotification": { "$schema": "http://json-schema.org/draft-07/schema#", - "description": "[UNSTABLE] Temporary notification payload for guardian approval review on a file change item. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary notification payload for guardian approval review on a file change item.", "properties": { "action": true, "itemId": { @@ -5550,7 +5550,7 @@ }, "McpToolCallGuardianApprovalReviewCompletedNotification": { "$schema": "http://json-schema.org/draft-07/schema#", - "description": "[UNSTABLE] Temporary notification payload for guardian approval review on an MCP tool call item. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary notification payload for guardian approval review on an MCP tool call item.", "properties": { "action": true, "itemId": { @@ -5577,7 +5577,7 @@ }, "McpToolCallGuardianApprovalReviewStartedNotification": { "$schema": "http://json-schema.org/draft-07/schema#", - "description": "[UNSTABLE] Temporary notification payload for guardian approval review on an MCP tool call item. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary notification payload for guardian approval review on an MCP tool call item.", "properties": { "action": true, "itemId": { diff --git a/codex-rs/app-server-protocol/schema/json/v2/CommandExecutionGuardianApprovalReviewCompletedNotification.json b/codex-rs/app-server-protocol/schema/json/v2/CommandExecutionGuardianApprovalReviewCompletedNotification.json index 79c25bcbd4..f385350d73 100644 --- a/codex-rs/app-server-protocol/schema/json/v2/CommandExecutionGuardianApprovalReviewCompletedNotification.json +++ b/codex-rs/app-server-protocol/schema/json/v2/CommandExecutionGuardianApprovalReviewCompletedNotification.json @@ -57,7 +57,7 @@ "type": "string" } }, - "description": "[UNSTABLE] Temporary notification payload for guardian approval review on a command execution item. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary notification payload for guardian approval review on a command execution item.", "properties": { "action": true, "itemId": { diff --git a/codex-rs/app-server-protocol/schema/json/v2/CommandExecutionGuardianApprovalReviewStartedNotification.json b/codex-rs/app-server-protocol/schema/json/v2/CommandExecutionGuardianApprovalReviewStartedNotification.json index d6fd35077a..8557855930 100644 --- a/codex-rs/app-server-protocol/schema/json/v2/CommandExecutionGuardianApprovalReviewStartedNotification.json +++ b/codex-rs/app-server-protocol/schema/json/v2/CommandExecutionGuardianApprovalReviewStartedNotification.json @@ -57,7 +57,7 @@ "type": "string" } }, - "description": "[UNSTABLE] Temporary notification payload for guardian approval review on a command execution item. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary notification payload for guardian approval review on a command execution item.", "properties": { "action": true, "itemId": { diff --git a/codex-rs/app-server-protocol/schema/json/v2/FileChangeGuardianApprovalReviewCompletedNotification.json b/codex-rs/app-server-protocol/schema/json/v2/FileChangeGuardianApprovalReviewCompletedNotification.json index d31c276b51..1def5d1a2a 100644 --- a/codex-rs/app-server-protocol/schema/json/v2/FileChangeGuardianApprovalReviewCompletedNotification.json +++ b/codex-rs/app-server-protocol/schema/json/v2/FileChangeGuardianApprovalReviewCompletedNotification.json @@ -57,7 +57,7 @@ "type": "string" } }, - "description": "[UNSTABLE] Temporary notification payload for guardian approval review on a file change item. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary notification payload for guardian approval review on a file change item.", "properties": { "action": true, "itemId": { diff --git a/codex-rs/app-server-protocol/schema/json/v2/FileChangeGuardianApprovalReviewStartedNotification.json b/codex-rs/app-server-protocol/schema/json/v2/FileChangeGuardianApprovalReviewStartedNotification.json index 59ebfb6176..b467f07e2b 100644 --- a/codex-rs/app-server-protocol/schema/json/v2/FileChangeGuardianApprovalReviewStartedNotification.json +++ b/codex-rs/app-server-protocol/schema/json/v2/FileChangeGuardianApprovalReviewStartedNotification.json @@ -57,7 +57,7 @@ "type": "string" } }, - "description": "[UNSTABLE] Temporary notification payload for guardian approval review on a file change item. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary notification payload for guardian approval review on a file change item.", "properties": { "action": true, "itemId": { diff --git a/codex-rs/app-server-protocol/schema/json/v2/McpToolCallGuardianApprovalReviewCompletedNotification.json b/codex-rs/app-server-protocol/schema/json/v2/McpToolCallGuardianApprovalReviewCompletedNotification.json index 45847e1564..1fd412c98a 100644 --- a/codex-rs/app-server-protocol/schema/json/v2/McpToolCallGuardianApprovalReviewCompletedNotification.json +++ b/codex-rs/app-server-protocol/schema/json/v2/McpToolCallGuardianApprovalReviewCompletedNotification.json @@ -57,7 +57,7 @@ "type": "string" } }, - "description": "[UNSTABLE] Temporary notification payload for guardian approval review on an MCP tool call item. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary notification payload for guardian approval review on an MCP tool call item.", "properties": { "action": true, "itemId": { diff --git a/codex-rs/app-server-protocol/schema/json/v2/McpToolCallGuardianApprovalReviewStartedNotification.json b/codex-rs/app-server-protocol/schema/json/v2/McpToolCallGuardianApprovalReviewStartedNotification.json index c32d63894b..1b80ef2e66 100644 --- a/codex-rs/app-server-protocol/schema/json/v2/McpToolCallGuardianApprovalReviewStartedNotification.json +++ b/codex-rs/app-server-protocol/schema/json/v2/McpToolCallGuardianApprovalReviewStartedNotification.json @@ -57,7 +57,7 @@ "type": "string" } }, - "description": "[UNSTABLE] Temporary notification payload for guardian approval review on an MCP tool call item. This shape is expected to change soon.", + "description": "[UNSTABLE] Temporary notification payload for guardian approval review on an MCP tool call item.", "properties": { "action": true, "itemId": { diff --git a/codex-rs/app-server-protocol/schema/typescript/v2/CommandExecutionGuardianApprovalReviewCompletedNotification.ts b/codex-rs/app-server-protocol/schema/typescript/v2/CommandExecutionGuardianApprovalReviewCompletedNotification.ts index 79b54528ec..55dbb3fe45 100644 --- a/codex-rs/app-server-protocol/schema/typescript/v2/CommandExecutionGuardianApprovalReviewCompletedNotification.ts +++ b/codex-rs/app-server-protocol/schema/typescript/v2/CommandExecutionGuardianApprovalReviewCompletedNotification.ts @@ -6,6 +6,6 @@ import type { GuardianApprovalReview } from "./GuardianApprovalReview"; /** * [UNSTABLE] Temporary notification payload for guardian approval review on a - * command execution item. This shape is expected to change soon. + * command execution item. */ export type CommandExecutionGuardianApprovalReviewCompletedNotification = { threadId: string, turnId: string, itemId: string, review: GuardianApprovalReview, action: JsonValue | null, }; diff --git a/codex-rs/app-server-protocol/schema/typescript/v2/CommandExecutionGuardianApprovalReviewStartedNotification.ts b/codex-rs/app-server-protocol/schema/typescript/v2/CommandExecutionGuardianApprovalReviewStartedNotification.ts index fcfca55654..a123632e90 100644 --- a/codex-rs/app-server-protocol/schema/typescript/v2/CommandExecutionGuardianApprovalReviewStartedNotification.ts +++ b/codex-rs/app-server-protocol/schema/typescript/v2/CommandExecutionGuardianApprovalReviewStartedNotification.ts @@ -6,6 +6,6 @@ import type { GuardianApprovalReview } from "./GuardianApprovalReview"; /** * [UNSTABLE] Temporary notification payload for guardian approval review on a - * command execution item. This shape is expected to change soon. + * command execution item. */ export type CommandExecutionGuardianApprovalReviewStartedNotification = { threadId: string, turnId: string, itemId: string, review: GuardianApprovalReview, action: JsonValue | null, }; diff --git a/codex-rs/app-server-protocol/schema/typescript/v2/FileChangeGuardianApprovalReviewCompletedNotification.ts b/codex-rs/app-server-protocol/schema/typescript/v2/FileChangeGuardianApprovalReviewCompletedNotification.ts index 5c26ff7259..6c12cfaca3 100644 --- a/codex-rs/app-server-protocol/schema/typescript/v2/FileChangeGuardianApprovalReviewCompletedNotification.ts +++ b/codex-rs/app-server-protocol/schema/typescript/v2/FileChangeGuardianApprovalReviewCompletedNotification.ts @@ -6,6 +6,6 @@ import type { GuardianApprovalReview } from "./GuardianApprovalReview"; /** * [UNSTABLE] Temporary notification payload for guardian approval review on a - * file change item. This shape is expected to change soon. + * file change item. */ export type FileChangeGuardianApprovalReviewCompletedNotification = { threadId: string, turnId: string, itemId: string, review: GuardianApprovalReview, action: JsonValue | null, }; diff --git a/codex-rs/app-server-protocol/schema/typescript/v2/FileChangeGuardianApprovalReviewStartedNotification.ts b/codex-rs/app-server-protocol/schema/typescript/v2/FileChangeGuardianApprovalReviewStartedNotification.ts index 2b19890ad3..bfda9d2572 100644 --- a/codex-rs/app-server-protocol/schema/typescript/v2/FileChangeGuardianApprovalReviewStartedNotification.ts +++ b/codex-rs/app-server-protocol/schema/typescript/v2/FileChangeGuardianApprovalReviewStartedNotification.ts @@ -6,6 +6,6 @@ import type { GuardianApprovalReview } from "./GuardianApprovalReview"; /** * [UNSTABLE] Temporary notification payload for guardian approval review on a - * file change item. This shape is expected to change soon. + * file change item. */ export type FileChangeGuardianApprovalReviewStartedNotification = { threadId: string, turnId: string, itemId: string, review: GuardianApprovalReview, action: JsonValue | null, }; diff --git a/codex-rs/app-server-protocol/schema/typescript/v2/McpToolCallGuardianApprovalReviewCompletedNotification.ts b/codex-rs/app-server-protocol/schema/typescript/v2/McpToolCallGuardianApprovalReviewCompletedNotification.ts index 52bdfaec79..1db213451a 100644 --- a/codex-rs/app-server-protocol/schema/typescript/v2/McpToolCallGuardianApprovalReviewCompletedNotification.ts +++ b/codex-rs/app-server-protocol/schema/typescript/v2/McpToolCallGuardianApprovalReviewCompletedNotification.ts @@ -6,6 +6,6 @@ import type { GuardianApprovalReview } from "./GuardianApprovalReview"; /** * [UNSTABLE] Temporary notification payload for guardian approval review on - * an MCP tool call item. This shape is expected to change soon. + * an MCP tool call item. */ export type McpToolCallGuardianApprovalReviewCompletedNotification = { threadId: string, turnId: string, itemId: string, review: GuardianApprovalReview, action: JsonValue | null, }; diff --git a/codex-rs/app-server-protocol/schema/typescript/v2/McpToolCallGuardianApprovalReviewStartedNotification.ts b/codex-rs/app-server-protocol/schema/typescript/v2/McpToolCallGuardianApprovalReviewStartedNotification.ts index df5a687812..41c8394ad4 100644 --- a/codex-rs/app-server-protocol/schema/typescript/v2/McpToolCallGuardianApprovalReviewStartedNotification.ts +++ b/codex-rs/app-server-protocol/schema/typescript/v2/McpToolCallGuardianApprovalReviewStartedNotification.ts @@ -6,6 +6,6 @@ import type { GuardianApprovalReview } from "./GuardianApprovalReview"; /** * [UNSTABLE] Temporary notification payload for guardian approval review on - * an MCP tool call item. This shape is expected to change soon. + * an MCP tool call item. */ export type McpToolCallGuardianApprovalReviewStartedNotification = { threadId: string, turnId: string, itemId: string, review: GuardianApprovalReview, action: JsonValue | null, }; diff --git a/codex-rs/app-server-protocol/src/protocol/v2.rs b/codex-rs/app-server-protocol/src/protocol/v2.rs index a9f2f72a1e..78d770e113 100644 --- a/codex-rs/app-server-protocol/src/protocol/v2.rs +++ b/codex-rs/app-server-protocol/src/protocol/v2.rs @@ -4829,7 +4829,7 @@ pub struct ItemStartedNotification { #[serde(rename_all = "camelCase")] #[ts(export_to = "v2/")] /// [UNSTABLE] Temporary notification payload for guardian approval review on a -/// command execution item. This shape is expected to change soon. +/// command execution item. pub struct CommandExecutionGuardianApprovalReviewStartedNotification { pub thread_id: String, pub turn_id: String, @@ -4842,7 +4842,7 @@ pub struct CommandExecutionGuardianApprovalReviewStartedNotification { #[serde(rename_all = "camelCase")] #[ts(export_to = "v2/")] /// [UNSTABLE] Temporary notification payload for guardian approval review on a -/// command execution item. This shape is expected to change soon. +/// command execution item. pub struct CommandExecutionGuardianApprovalReviewCompletedNotification { pub thread_id: String, pub turn_id: String, @@ -4855,7 +4855,7 @@ pub struct CommandExecutionGuardianApprovalReviewCompletedNotification { #[serde(rename_all = "camelCase")] #[ts(export_to = "v2/")] /// [UNSTABLE] Temporary notification payload for guardian approval review on a -/// file change item. This shape is expected to change soon. +/// file change item. pub struct FileChangeGuardianApprovalReviewStartedNotification { pub thread_id: String, pub turn_id: String, @@ -4868,7 +4868,7 @@ pub struct FileChangeGuardianApprovalReviewStartedNotification { #[serde(rename_all = "camelCase")] #[ts(export_to = "v2/")] /// [UNSTABLE] Temporary notification payload for guardian approval review on a -/// file change item. This shape is expected to change soon. +/// file change item. pub struct FileChangeGuardianApprovalReviewCompletedNotification { pub thread_id: String, pub turn_id: String, @@ -4881,7 +4881,7 @@ pub struct FileChangeGuardianApprovalReviewCompletedNotification { #[serde(rename_all = "camelCase")] #[ts(export_to = "v2/")] /// [UNSTABLE] Temporary notification payload for guardian approval review on -/// an MCP tool call item. This shape is expected to change soon. +/// an MCP tool call item. pub struct McpToolCallGuardianApprovalReviewStartedNotification { pub thread_id: String, pub turn_id: String, @@ -4894,7 +4894,7 @@ pub struct McpToolCallGuardianApprovalReviewStartedNotification { #[serde(rename_all = "camelCase")] #[ts(export_to = "v2/")] /// [UNSTABLE] Temporary notification payload for guardian approval review on -/// an MCP tool call item. This shape is expected to change soon. +/// an MCP tool call item. pub struct McpToolCallGuardianApprovalReviewCompletedNotification { pub thread_id: String, pub turn_id: String,