mirror of
https://github.com/openai/codex.git
synced 2026-11-19 22:30:42 +00:00
Build V8 from source by default in Bazel (#57832)
## Why Source-built V8 archives and generated Rust bindings must agree on their ABI, including in debug builds. Linux platform selection must also distinguish GNU and musl when using LLVM platforms. ## What changed - Always select source-built V8 archives and matching bindings for Bazel consumers, removing the `rusty_v8_from_source` flag. - Use LLVM's libc-aware Linux selectors for archives, bindings, headers, and bindgen targets. - Keep `V8_ENABLE_CHECKS` undefined in debug builds to match Rust's `HandleScope` layout, and set `V8_LOGGING_LEVEL=2` for debug verification. - Include compiler-rt builtins in the ARM64 GNU/Linux archive to provide `__clear_cache`. - Set the Intel macOS minimum version for `codex-code-mode-host` releases to 10.13 for V8's aligned allocation support. ## Testing Always include the existing ignored CppGC ABI checks in Bazel `v8-poc` unit tests and remove their exclusion from Bazel CI. GitOrigin-RevId: f698a47502154cdfb80febed02e4465d9f2d1e0c
This commit is contained in:
@@ -152,7 +152,7 @@ def runtime_archive(name, srcs, **kwargs):
|
||||
**kwargs
|
||||
)
|
||||
|
||||
def release_binary(binary, name = "release", **kwargs):
|
||||
def release_binary(binary, name = "release", macos_x86_64_minimum_os = "10.12", **kwargs):
|
||||
"""Expose release_files and release.tar.gz; override name for sibling binaries."""
|
||||
kwargs.setdefault("tags", ["manual"])
|
||||
kwargs.setdefault("visibility", ["//visibility:public"])
|
||||
@@ -166,7 +166,7 @@ def release_binary(binary, name = "release", **kwargs):
|
||||
}),
|
||||
macos_minimum_os = select({
|
||||
"@platforms//cpu:aarch64": "11.0",
|
||||
"//conditions:default": "10.12",
|
||||
"//conditions:default": macos_x86_64_minimum_os,
|
||||
}),
|
||||
symbol_group = select({
|
||||
"@platforms//os:macos": "dsym_folder",
|
||||
|
||||
Reference in New Issue
Block a user