From a915190b387e9c8f77b7f1214f1c36f01f0c1021 Mon Sep 17 00:00:00 2001 From: "kh.ai" Date: Fri, 17 Oct 2025 11:20:59 -0700 Subject: [PATCH] Cap auto-scope suggestions to up to 20 directories --- codex-rs/tui/src/chatwidget.rs | 27 ++++++++++++++------------- codex-rs/tui/src/security_review.rs | 3 ++- 2 files changed, 16 insertions(+), 14 deletions(-) diff --git a/codex-rs/tui/src/chatwidget.rs b/codex-rs/tui/src/chatwidget.rs index 1f4a8dacc8..a473c9f739 100644 --- a/codex-rs/tui/src/chatwidget.rs +++ b/codex-rs/tui/src/chatwidget.rs @@ -2211,16 +2211,13 @@ impl ChatWidget { } let mut scope_prompt = scope_prompt; - if resolved_paths.is_empty() && scope_prompt.is_none() { - let default_prompt = match mode { - SecurityReviewMode::Full => { - "Identify the most security-relevant directories (3-8) for a comprehensive review. Focus on production services, externally reachable interfaces, auth/authz modules, secret management, and critical infrastructure. Exclude tests, vendor bundles, docs, and generated files." - } - SecurityReviewMode::Bugs => { - "Suggest the smallest set of directories (3-8) most likely to contain exploitable bugs. Prioritise request parsing, input validation, authentication, authorisation, and secret handling. Skip tests, vendor bundles, docs, and generated files." - } - }; - scope_prompt = Some(default_prompt.to_string()); + if matches!(mode, SecurityReviewMode::Bugs) + && resolved_paths.is_empty() + && scope_prompt.is_none() + { + scope_prompt = Some( + "Suggest up to 20 directories most likely to contain exploitable bugs. Prioritise request parsing, input validation, authentication, authorisation, and secret handling. Skip tests, vendor bundles, docs, and generated files.".to_string(), + ); } let mut context_paths = display_paths.clone(); @@ -2268,9 +2265,13 @@ impl ChatWidget { last_log: None, }); - let annotated_scope_prompt = scope_prompt - .as_ref() - .map(|prompt| annotate_scope_prompt(prompt.as_str())); + let annotated_scope_prompt = if matches!(mode, SecurityReviewMode::Bugs) { + scope_prompt + .as_ref() + .map(|prompt| annotate_scope_prompt(prompt.as_str())) + } else { + None + }; let request = SecurityReviewRequest { repo_path, diff --git a/codex-rs/tui/src/security_review.rs b/codex-rs/tui/src/security_review.rs index b4fd65d0bc..431343dce4 100644 --- a/codex-rs/tui/src/security_review.rs +++ b/codex-rs/tui/src/security_review.rs @@ -725,7 +725,8 @@ pub(crate) async fn run_security_review( let mut include_paths = request.include_paths.clone(); let git_link_info = build_git_link_info(&repo_path).await; - if include_paths.is_empty() + if matches!(request.mode, SecurityReviewMode::Bugs) + && include_paths.is_empty() && let Some(prompt) = request.auto_scope_prompt.as_ref().and_then(|value| { let trimmed = value.trim(); if trimmed.is_empty() {