diff --git a/.github/workflows/rust-ci.yml b/.github/workflows/rust-ci.yml index c203e2b742..7115502364 100644 --- a/.github/workflows/rust-ci.yml +++ b/.github/workflows/rust-ci.yml @@ -494,8 +494,10 @@ jobs: # Save caches explicitly; make non-fatal so cache packaging # never fails the overall job. Only save when key wasn't hit. + # Lint/build jobs already save this cache key. Skipping the redundant + # Windows test-job save keeps the test jobs within their timeout budget. - name: Save cargo home cache - if: always() && !cancelled() && steps.cache_cargo_home_restore.outputs.cache-hit != 'true' + if: always() && !cancelled() && !startsWith(matrix.runner, 'windows') && steps.cache_cargo_home_restore.outputs.cache-hit != 'true' continue-on-error: true uses: actions/cache/save@v5 with: diff --git a/codex-rs/login/src/onboard_oauth_helper.rs b/codex-rs/login/src/onboard_oauth_helper.rs index 76678031a5..5787cc9c40 100644 --- a/codex-rs/login/src/onboard_oauth_helper.rs +++ b/codex-rs/login/src/onboard_oauth_helper.rs @@ -511,14 +511,17 @@ fn handle_callback_request( Ok(url) => url, Err(err) => { return CallbackResponse { - response: html_response(400, format!("
{err}
")), + response: html_response( + /*status*/ 400, + format!("{err}
"), + ), result: None, }; } }; if parsed_url.path() != callback_path { return CallbackResponse { - response: html_response(404, "Return to your terminal.
".to_string(), ), result: Some(Err(message)), @@ -546,13 +549,16 @@ fn handle_callback_request( match params.get("code") { Some(code) if !code.is_empty() => CallbackResponse { response: html_response( - 200, + /*status*/ 200, "You can return to your terminal.
".to_string(), ), result: Some(Ok(code.clone())), }, _ => CallbackResponse { - response: html_response(400, "