mirror of
https://github.com/openai/codex.git
synced 2026-10-29 19:08:43 +00:00
Always use private desktops for legacy Windows sandboxes (#46554)
## What changed - Remove the private-desktop opt-out from elevated and unelevated Windows sandbox launches. - Remove `windows.sandbox_private_desktop` and its managed requirement and API fields. Warn users to remove the obsolete setting. - Require a private desktop name when launching through the Windows sandbox wrapper and command runner. ## Testing Add coverage for the obsolete-setting migration warning and update wrapper tests to verify a live private desktop is passed and a missing desktop name is rejected. GitOrigin-RevId: c7135f8d211aac8d812180691c2c1e433d77cde4
This commit is contained in:
@@ -206,14 +206,6 @@ fn render_debug_config_lines(
|
||||
));
|
||||
}
|
||||
|
||||
if let Some(sandbox_private_desktop) = requirements.windows_sandbox_private_desktop.as_ref() {
|
||||
requirement_lines.push(requirement_line(
|
||||
"windows.sandbox_private_desktop",
|
||||
sandbox_private_desktop.value.to_string(),
|
||||
Some(&sandbox_private_desktop.source),
|
||||
));
|
||||
}
|
||||
|
||||
if let Some(policies) = requirements_toml.allowed_approval_policies.as_ref() {
|
||||
let value = join_or_empty(policies.iter().map(ToString::to_string).collect::<Vec<_>>());
|
||||
requirement_lines.push(requirement_line(
|
||||
@@ -865,10 +857,6 @@ interrupt_message = false
|
||||
},
|
||||
RequirementSource::LegacyManagedConfigTomlFromMdm,
|
||||
)),
|
||||
windows_sandbox_private_desktop: Some(Sourced::new(
|
||||
/*value*/ false,
|
||||
RequirementSource::LegacyManagedConfigTomlFromMdm,
|
||||
)),
|
||||
approval_policy: ConstrainedWithSource::new(
|
||||
Constrained::allow_any(AskForApproval::OnRequest.to_core()),
|
||||
Some(RequirementSource::LegacyManagedConfigTomlFromMdm),
|
||||
@@ -986,7 +974,6 @@ interrupt_message = false
|
||||
in_app_browser: None,
|
||||
windows: Some(WindowsRequirementsToml {
|
||||
allowed_sandbox_implementations: None,
|
||||
sandbox_private_desktop: Some(false),
|
||||
}),
|
||||
additional_developer_instructions: None,
|
||||
guardian_policy_config: Some("Use the managed guardian policy.".to_string()),
|
||||
|
||||
Reference in New Issue
Block a user