chore: enforce argument-comment lint across all targets

This commit is contained in:
Michael Bolin
2026-03-27 16:14:21 -07:00
parent 5b71e5104f
commit a4fa041e7f
359 changed files with 10414 additions and 6807 deletions
+8 -5
View File
@@ -524,14 +524,14 @@ mod tests {
#[test]
fn test_heredoc() {
assert_match(&heredoc_script(""), None);
assert_match(&heredoc_script(""), /*expected_workdir*/ None);
}
#[test]
fn test_heredoc_non_login_shell() {
let script = heredoc_script("");
let args = strs_to_strings(&["bash", "-c", &script]);
assert_match_args(args, None);
assert_match_args(args, /*expected_workdir*/ None);
}
#[test]
@@ -565,17 +565,20 @@ PATCH"#,
#[test]
fn test_powershell_heredoc() {
let script = heredoc_script("");
assert_match_args(args_powershell(&script), None);
assert_match_args(args_powershell(&script), /*expected_workdir*/ None);
}
#[test]
fn test_powershell_heredoc_no_profile() {
let script = heredoc_script("");
assert_match_args(args_powershell_no_profile(&script), None);
assert_match_args(
args_powershell_no_profile(&script),
/*expected_workdir*/ None,
);
}
#[test]
fn test_pwsh_heredoc() {
let script = heredoc_script("");
assert_match_args(args_pwsh(&script), None);
assert_match_args(args_pwsh(&script), /*expected_workdir*/ None);
}
#[test]
+24 -8
View File
@@ -672,7 +672,7 @@ fn test_parse_patch_lenient() {
#[test]
fn test_parse_one_hunk() {
assert_eq!(
parse_one_hunk(&["bad"], 234),
parse_one_hunk(&["bad"], /*line_number*/ 234),
Err(InvalidHunkError {
message: "'bad' is not a valid hunk header. \
Valid hunk headers: '*** Add File: {path}', '*** Delete File: {path}', '*** Update File: {path}'".to_string(),
@@ -685,7 +685,11 @@ fn test_parse_one_hunk() {
#[test]
fn test_update_file_chunk() {
assert_eq!(
parse_update_file_chunk(&["bad"], 123, false),
parse_update_file_chunk(
&["bad"],
/*line_number*/ 123,
/*allow_missing_context*/ false
),
Err(InvalidHunkError {
message: "Expected update hunk to start with a @@ context marker, got: 'bad'"
.to_string(),
@@ -693,14 +697,18 @@ fn test_update_file_chunk() {
})
);
assert_eq!(
parse_update_file_chunk(&["@@"], 123, false),
parse_update_file_chunk(
&["@@"],
/*line_number*/ 123,
/*allow_missing_context*/ false
),
Err(InvalidHunkError {
message: "Update hunk does not contain any lines".to_string(),
line_number: 124
})
);
assert_eq!(
parse_update_file_chunk(&["@@", "bad"], 123, false),
parse_update_file_chunk(&["@@", "bad"], /*line_number*/ 123, /*allow_missing_context*/ false),
Err(InvalidHunkError {
message: "Unexpected line found in update hunk: 'bad'. \
Every line should start with ' ' (context line), '+' (added line), or '-' (removed line)".to_string(),
@@ -708,7 +716,11 @@ fn test_update_file_chunk() {
})
);
assert_eq!(
parse_update_file_chunk(&["@@", "*** End of File"], 123, false),
parse_update_file_chunk(
&["@@", "*** End of File"],
/*line_number*/ 123,
/*allow_missing_context*/ false
),
Err(InvalidHunkError {
message: "Update hunk does not contain any lines".to_string(),
line_number: 124
@@ -725,8 +737,8 @@ fn test_update_file_chunk() {
" context2",
"*** End Patch",
],
123,
false
/*line_number*/ 123,
/*allow_missing_context*/ false
),
Ok((
(UpdateFileChunk {
@@ -749,7 +761,11 @@ fn test_update_file_chunk() {
))
);
assert_eq!(
parse_update_file_chunk(&["@@", "+line", "*** End of File"], 123, false),
parse_update_file_chunk(
&["@@", "+line", "*** End of File"],
/*line_number*/ 123,
/*allow_missing_context*/ false
),
Ok((
(UpdateFileChunk {
change_context: None,
+16 -4
View File
@@ -122,7 +122,10 @@ mod tests {
fn test_exact_match_finds_sequence() {
let lines = to_vec(&["foo", "bar", "baz"]);
let pattern = to_vec(&["bar", "baz"]);
assert_eq!(seek_sequence(&lines, &pattern, 0, false), Some(1));
assert_eq!(
seek_sequence(&lines, &pattern, /*start*/ 0, /*eof*/ false),
Some(1)
);
}
#[test]
@@ -130,7 +133,10 @@ mod tests {
let lines = to_vec(&["foo ", "bar\t\t"]);
// Pattern omits trailing whitespace.
let pattern = to_vec(&["foo", "bar"]);
assert_eq!(seek_sequence(&lines, &pattern, 0, false), Some(0));
assert_eq!(
seek_sequence(&lines, &pattern, /*start*/ 0, /*eof*/ false),
Some(0)
);
}
#[test]
@@ -138,7 +144,10 @@ mod tests {
let lines = to_vec(&[" foo ", " bar\t"]);
// Pattern omits any additional whitespace.
let pattern = to_vec(&["foo", "bar"]);
assert_eq!(seek_sequence(&lines, &pattern, 0, false), Some(0));
assert_eq!(
seek_sequence(&lines, &pattern, /*start*/ 0, /*eof*/ false),
Some(0)
);
}
#[test]
@@ -146,6 +155,9 @@ mod tests {
let lines = to_vec(&["just one line"]);
let pattern = to_vec(&["too", "many", "lines"]);
// Should not panic – must return None when pattern cannot possibly fit.
assert_eq!(seek_sequence(&lines, &pattern, 0, false), None);
assert_eq!(
seek_sequence(&lines, &pattern, /*start*/ 0, /*eof*/ false),
None
);
}
}