mirror of
https://github.com/openai/codex.git
synced 2026-11-16 22:00:36 +00:00
Move fullscreen transcript control to TUI configuration (#46849)
## What changed Use `tui.fullscreen_transcript` to opt into the fullscreen transcript, including scrolling, selection, and search. It defaults to `false`; `--no-alt-screen` and `tui.alternate_screen = "never"` still take precedence. The new preference controls both the first frame and application startup. Boolean CLI overrides for it are allowed during daemon startup. The old `features.transcript_v2` flag is deprecated and ignored, with a notice directing users to the new setting; it does not migrate into or override the preference. ## Testing Add coverage for default terminal scrollback, fullscreen persistence through startup, alternate-screen restrictions, daemon override validation, and independence from the deprecated flag. Update existing history and activity tests to use the new preference. GitOrigin-RevId: 4117bf1ee548fa8d101a594f9506673d87c74c15
This commit is contained in:
@@ -5,7 +5,6 @@ use crate::legacy_core::config::ConfigBuilder;
|
||||
use crate::legacy_core::config::TerminalResizeReflowMaxRows;
|
||||
use crate::local_settings::LocalSettings;
|
||||
use codex_config::types::AltScreenMode;
|
||||
use codex_features::Feature;
|
||||
use pretty_assertions::assert_eq;
|
||||
use std::collections::HashSet;
|
||||
|
||||
@@ -42,10 +41,7 @@ async fn owned_initial_history_stops_after_viewport_or_scan_budget() {
|
||||
.build()
|
||||
.await
|
||||
.expect("config");
|
||||
config
|
||||
.features
|
||||
.enable(Feature::TranscriptV2)
|
||||
.expect("enable owned transcript");
|
||||
config.tui_fullscreen_transcript = true;
|
||||
config.tui_alternate_screen = AltScreenMode::Always;
|
||||
config.terminal_resize_reflow.max_rows = TerminalResizeReflowMaxRows::Disabled;
|
||||
let local_settings = LocalSettings::from(&config);
|
||||
@@ -78,10 +74,7 @@ async fn owned_initial_history_stops_after_viewport_or_scan_budget() {
|
||||
Some(100),
|
||||
);
|
||||
|
||||
config
|
||||
.features
|
||||
.disable(Feature::TranscriptV2)
|
||||
.expect("disable owned transcript");
|
||||
config.tui_fullscreen_transcript = false;
|
||||
// The mode selected at launch wins even if thread config changes or is unavailable.
|
||||
for config in [Some(&config), None] {
|
||||
let budget = HistoryLoadBudget::new(
|
||||
|
||||
Reference in New Issue
Block a user