From a08e852b059342cd8275592aa7b76be4db9ebe03 Mon Sep 17 00:00:00 2001 From: Charles Cunningham Date: Tue, 17 Mar 2026 04:01:24 -0700 Subject: [PATCH] Fix BTW argument-comment lint Co-authored-by: Codex --- codex-rs/tui/src/app/btw.rs | 9 ++++++--- codex-rs/tui/src/chatwidget/tests.rs | 2 +- codex-rs/tui_app_server/src/app/btw.rs | 9 ++++++--- codex-rs/tui_app_server/src/chatwidget/tests.rs | 2 +- 4 files changed, 14 insertions(+), 8 deletions(-) diff --git a/codex-rs/tui/src/app/btw.rs b/codex-rs/tui/src/app/btw.rs index d8839716d0..d58d291389 100644 --- a/codex-rs/tui/src/app/btw.rs +++ b/codex-rs/tui/src/app/btw.rs @@ -14,7 +14,7 @@ impl App { /// Keeps BTW-specific UI state in sync with the currently displayed thread. pub(super) fn sync_btw_thread_ui(&mut self) { let clear_btw_ui = |chat_widget: &mut crate::chatwidget::ChatWidget| { - chat_widget.set_thread_footer_hint_override(None); + chat_widget.set_thread_footer_hint_override(/*items*/ None); chat_widget.clear_thread_rename_block(); }; let Some(active_thread_id) = self.current_displayed_thread_id() else { @@ -163,8 +163,11 @@ impl App { parent_thread_id: ThreadId, user_message: crate::chatwidget::UserMessage, ) -> Result { - self.session_telemetry - .counter("codex.thread.btw", 1, &[("source", "slash_command")]); + self.session_telemetry.counter( + "codex.thread.btw", + /*inc*/ 1, + &[("source", "slash_command")], + ); self.refresh_in_memory_config_from_disk_best_effort("starting a BTW subagent") .await; let parent_rollout_path = match self.server.get_thread(parent_thread_id).await { diff --git a/codex-rs/tui/src/chatwidget/tests.rs b/codex-rs/tui/src/chatwidget/tests.rs index 8d60e8edbc..21cfdd5071 100644 --- a/codex-rs/tui/src/chatwidget/tests.rs +++ b/codex-rs/tui/src/chatwidget/tests.rs @@ -11905,7 +11905,7 @@ async fn clearing_thread_footer_override_preserves_general_footer_hint_snapshot( "BTW".to_string(), "from main thread · Esc to return".to_string(), )])); - chat.set_thread_footer_hint_override(None); + chat.set_thread_footer_hint_override(/*items*/ None); let width = 80; let height = chat.desired_height(width); diff --git a/codex-rs/tui_app_server/src/app/btw.rs b/codex-rs/tui_app_server/src/app/btw.rs index 2b08199746..63fb1cd568 100644 --- a/codex-rs/tui_app_server/src/app/btw.rs +++ b/codex-rs/tui_app_server/src/app/btw.rs @@ -13,7 +13,7 @@ pub(super) struct BtwThreadState { impl App { pub(super) fn sync_btw_thread_ui(&mut self) { let clear_btw_ui = |chat_widget: &mut crate::chatwidget::ChatWidget| { - chat_widget.set_thread_footer_hint_override(None); + chat_widget.set_thread_footer_hint_override(/*items*/ None); chat_widget.clear_thread_rename_block(); }; let Some(active_thread_id) = self.current_displayed_thread_id() else { @@ -183,8 +183,11 @@ impl App { parent_thread_id: ThreadId, user_message: crate::chatwidget::UserMessage, ) -> Result { - self.session_telemetry - .counter("codex.thread.btw", 1, &[("source", "slash_command")]); + self.session_telemetry.counter( + "codex.thread.btw", + /*inc*/ 1, + &[("source", "slash_command")], + ); self.refresh_in_memory_config_from_disk_best_effort("starting a BTW subagent") .await; diff --git a/codex-rs/tui_app_server/src/chatwidget/tests.rs b/codex-rs/tui_app_server/src/chatwidget/tests.rs index 848c00dfa2..3576482dc0 100644 --- a/codex-rs/tui_app_server/src/chatwidget/tests.rs +++ b/codex-rs/tui_app_server/src/chatwidget/tests.rs @@ -12317,7 +12317,7 @@ async fn clearing_thread_footer_override_preserves_general_footer_hint_snapshot( "BTW".to_string(), "from main thread · Esc to return".to_string(), )])); - chat.set_thread_footer_hint_override(None); + chat.set_thread_footer_hint_override(/*items*/ None); let width = 80; let height = chat.desired_height(width);