From 9f90992bb9d68550fc86d74c759cfede298548bf Mon Sep 17 00:00:00 2001 From: David Wiesen Date: Thu, 7 May 2026 12:03:42 -0700 Subject: [PATCH] fix(windows-sandbox): tolerate preflight ACL probe failures during refresh --- codex-rs/windows-sandbox-rs/src/setup_main_win.rs | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/codex-rs/windows-sandbox-rs/src/setup_main_win.rs b/codex-rs/windows-sandbox-rs/src/setup_main_win.rs index ca3fc1e444..3917308cd7 100644 --- a/codex-rs/windows-sandbox-rs/src/setup_main_win.rs +++ b/codex-rs/windows-sandbox-rs/src/setup_main_win.rs @@ -689,11 +689,10 @@ fn run_setup_full(payload: &Payload, log: &mut File, sbx_dir: &Path) -> Result<( match path_mask_allows(root, &[psid], write_mask, /*require_all_bits*/ true) { Ok(h) => h, Err(e) => { - refresh_errors.push(format!( - "write mask check failed on {} for {label}: {}", - root.display(), - e - )); + // Some Windows ACL layouts can make the preflight mask probe fail even + // though we can still normalize the path by adding the needed allow ACEs. + // Treat probe failures as best-effort diagnostics and fall back to the + // repair path below instead of aborting refresh early. log_line( log, &format!(