mirror of
https://github.com/openai/codex.git
synced 2026-11-16 22:00:36 +00:00
Separate TUI preferences from server configuration (#42202)
## Why TUI preferences and persistence paths belong to the local client, while thread configuration and account requirements may come from the active app server. Keeping both in the same resolved `Config` can replace live local preferences when a thread is resumed, forked, reconnected, or switched. ## What changed - Add `LocalSettings` as the TUI-owned source for UI, history, notice, and local persistence settings, and preserve it across session lifecycle transitions. - Write preference changes to the selected user config file and reload local settings from disk when changing roots. - Use the app server's account response for authentication-dependent onboarding and status UI instead of the local model-provider configuration. - Retain platform family and OS metadata reported by remote app servers. ## Testing - Cover local setting defaults, overrides, persistence destinations, reloads, and preservation across widget replacement and root switching. - Cover remote platform metadata and server-controlled authentication UI. GitOrigin-RevId: dbc2965fb1d6cbecb3f973f6133f3dcd4467b753
This commit is contained in:
@@ -31,15 +31,16 @@ impl SessionStartAction {
|
||||
config: &Config,
|
||||
target: &SessionTarget,
|
||||
) -> Result<AppServerStartedThread> {
|
||||
let local_settings = crate::local_settings::LocalSettings::from(config);
|
||||
match self {
|
||||
Self::Resume(settings) => {
|
||||
app_server
|
||||
.resume_thread(config.clone(), target.thread_id, settings)
|
||||
.resume_thread(&local_settings, config.clone(), target.thread_id, settings)
|
||||
.await
|
||||
}
|
||||
Self::Fork => {
|
||||
app_server
|
||||
.fork_thread(config.clone(), target.thread_id)
|
||||
.fork_thread(&local_settings, config.clone(), target.thread_id)
|
||||
.await
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user