Separate TUI preferences from server configuration (#42202)

## Why

TUI preferences and persistence paths belong to the local client, while thread
configuration and account requirements may come from the active app server.
Keeping both in the same resolved `Config` can replace live local preferences
when a thread is resumed, forked, reconnected, or switched.

## What changed

- Add `LocalSettings` as the TUI-owned source for UI, history, notice, and local
  persistence settings, and preserve it across session lifecycle transitions.
- Write preference changes to the selected user config file and reload local
  settings from disk when changing roots.
- Use the app server's account response for authentication-dependent onboarding
  and status UI instead of the local model-provider configuration.
- Retain platform family and OS metadata reported by remote app servers.

## Testing

- Cover local setting defaults, overrides, persistence destinations, reloads,
  and preservation across widget replacement and root switching.
- Cover remote platform metadata and server-controlled authentication UI.

GitOrigin-RevId: dbc2965fb1d6cbecb3f973f6133f3dcd4467b753
This commit is contained in:
Eric Traut
2026-09-02 04:20:38 +00:00
committed by copyberry
parent 0b509e930e
commit 9d57be71ba
87 changed files with 1188 additions and 459 deletions
+11 -6
View File
@@ -13,12 +13,14 @@ impl ChatWidget {
) -> Self {
let ChatWidgetInit {
config,
local_settings,
frame_requester,
app_event_tx,
workspace_command_runner,
initial_user_message,
enhanced_keys_supported,
has_chatgpt_account,
requires_openai_auth,
has_codex_backend_auth,
model_catalog,
feedback,
@@ -65,11 +67,12 @@ impl ChatWidget {
let current_cwd = Some(config.cwd.to_path_buf());
let effective_service_tier = crate::service_tier_resolution::effective_service_tier(
&config,
&local_settings.notices,
&header_model,
&model_catalog.try_list_models().unwrap_or_default(),
);
let current_terminal_info = terminal_info();
let runtime_keymap = RuntimeKeymap::from_config(&config.tui_keymap).ok();
let runtime_keymap = RuntimeKeymap::from_config(&local_settings.tui.keymap).ok();
let default_keymap = RuntimeKeymap::defaults();
let copy_last_response_binding = runtime_keymap
.as_ref()
@@ -88,7 +91,7 @@ impl ChatWidget {
codex_http_client::ClientRouteClass::Other,
);
pets::start_configured_pet_load_if_needed(
&config,
&local_settings,
/*ambient_pet_missing*/ true,
frame_requester.clone(),
app_event_tx.clone(),
@@ -104,19 +107,21 @@ impl ChatWidget {
has_input_focus: true,
enhanced_keys_supported,
placeholder_text: placeholder.clone(),
disable_paste_burst: config.disable_paste_burst,
animations_enabled: config.animations,
disable_paste_burst: local_settings.tui.disable_paste_burst.unwrap_or(false),
animations_enabled: local_settings.tui.animations,
skills: None,
}),
transcript: TranscriptState::new(active_cell),
raw_output_mode: config.tui_raw_output_mode,
raw_output_mode: local_settings.tui.raw_output_mode,
config,
local_settings,
effective_service_tier,
skills_all: Vec::new(),
skills_initial_state: None,
current_collaboration_mode,
active_collaboration_mask,
has_chatgpt_account,
requires_openai_auth,
has_codex_backend_auth,
model_catalog,
model_popup_request_id: None,
@@ -265,7 +270,7 @@ impl ChatWidget {
if let Some(keymap) = runtime_keymap {
widget.bottom_pane.set_keymap_bindings(&keymap);
}
if widget.config.tui_vim_mode_default {
if widget.local_settings.tui.vim_mode_default {
widget.bottom_pane.enable_vim_in_insert_mode();
} else {
widget.bottom_pane.set_vim_enabled(/*enabled*/ false);