From 9cbe84748ede7da7ae48cdac9b2eb66fb747e406 Mon Sep 17 00:00:00 2001
From: kevin zhao <zhao@openai.com>
Date: Tue, 18 Nov 2025 10:15:30 -0800
Subject: [PATCH] addressing comments

---
 codex-rs/core/src/exec_policy.rs      | 15 ++++++++++-----
 codex-rs/core/src/tools/sandboxing.rs |  1 -
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/codex-rs/core/src/exec_policy.rs b/codex-rs/core/src/exec_policy.rs
index 3747be6f07..92cf6a12bb 100644
--- a/codex-rs/core/src/exec_policy.rs
+++ b/codex-rs/core/src/exec_policy.rs
@@ -61,12 +61,17 @@ pub(crate) fn exec_policy_for(
         }
     };
 
-    let mut policy_paths: Vec<PathBuf> = Vec::new();
+    let entries = entries
+        .map(|entry| {
+            entry.map_err(|source| ExecPolicyError::ReadDir {
+                dir: policy_dir.clone(),
+                source,
+            })
+        })
+        .collect::<Result<Vec<_>, _>>()?;
+
+    let mut policy_paths: Vec<PathBuf> = Vec::with_capacity(entries.len());
     for entry in entries {
-        let entry = entry.map_err(|source| ExecPolicyError::ReadDir {
-            dir: policy_dir.clone(),
-            source,
-        })?;
         let path = entry.path();
         if path
             .extension()
diff --git a/codex-rs/core/src/tools/sandboxing.rs b/codex-rs/core/src/tools/sandboxing.rs
index 08c766ab7f..739c743765 100644
--- a/codex-rs/core/src/tools/sandboxing.rs
+++ b/codex-rs/core/src/tools/sandboxing.rs
@@ -93,7 +93,6 @@ pub(crate) enum ApprovalRequirement {
     Forbidden { reason: String },
 }
 
-/// Reflects the orchestrator's behavior (pre-refactor):
 /// - Never, OnFailure: do not ask
 /// - OnRequest: ask unless sandbox policy is DangerFullAccess
 /// - UnlessTrusted: always ask