mirror of
https://github.com/openai/codex.git
synced 2026-11-20 22:40:37 +00:00
Return an assessment for explicit Guardian reviews (#62846)
## Why An explicit `thread/guardianReview` request could return a null assessment when live execution would skip approval, leaving callers without a verdict on the recorded action. ## What changed Require `assessment` on every successful `thread/guardianReview` response. Review eligible recorded calls even when a command is allowlisted, an MCP tool is configured for automatic approval or has a remembered approval, or the policy disables permission requests. The review runs without executing the call or granting permissions. Include the MCP server's owning environment permissions in the review context, matching live review. ## Testing Cover allowlisted commands, permission requests with prompting disabled, and automatically approved MCP tools. Compare live and recorded MCP review input for a server whose owning environment has denied paths. GitOrigin-RevId: 54689dc043d77f940e10d29842308340f6937980
This commit is contained in:
BIN
Binary file not shown.
@@ -1863,8 +1863,7 @@ pub struct ThreadGuardianReviewParams {
|
||||
#[ts(export_to = "v2/")]
|
||||
pub struct ThreadGuardianReviewResponse {
|
||||
pub call_id: String,
|
||||
/// Null when current policy or a remembered approval skips review.
|
||||
pub assessment: Option<ThreadGuardianAssessment>,
|
||||
pub assessment: ThreadGuardianAssessment,
|
||||
}
|
||||
|
||||
#[derive(Serialize, Deserialize, Debug, Clone, PartialEq, JsonSchema, TS)]
|
||||
|
||||
Reference in New Issue
Block a user