From 90d5445d0915a400fbfb2c5d258256cea63c7029 Mon Sep 17 00:00:00 2001
From: Ahmed Ibrahim <aibrahim@openai.com>
Date: Fri, 22 Aug 2025 11:15:54 -0700
Subject: [PATCH] refactor

---
 codex-rs/tui/src/app.rs                               | 9 ++-------
 codex-rs/tui/src/bottom_pane/chat_composer.rs         | 2 --
 codex-rs/tui/src/bottom_pane/chat_composer_history.rs | 2 --
 codex-rs/tui/src/chatwidget.rs                        | 2 --
 4 files changed, 2 insertions(+), 13 deletions(-)

diff --git a/codex-rs/tui/src/app.rs b/codex-rs/tui/src/app.rs
index 69e7fbd69c..4cb343a939 100644
--- a/codex-rs/tui/src/app.rs
+++ b/codex-rs/tui/src/app.rs
@@ -244,21 +244,16 @@ impl App {
                 self.chat_widget.apply_file_search_result(query, matches);
             }
             AppEvent::UpdateReasoningEffort(effort) => {
-                // Keep App-level config in sync with TUI so forks/new sessions inherit overrides.
                 self.chat_widget.set_reasoning_effort(effort);
-                self.config.model_reasoning_effort = effort;
             }
             AppEvent::UpdateModel(model) => {
-                self.chat_widget.set_model(model.clone());
-                self.config.model = model;
+                self.chat_widget.set_model(model);
             }
             AppEvent::UpdateAskForApprovalPolicy(policy) => {
                 self.chat_widget.set_approval_policy(policy);
-                self.config.approval_policy = policy;
             }
             AppEvent::UpdateSandboxPolicy(policy) => {
-                self.chat_widget.set_sandbox_policy(policy.clone());
-                self.config.sandbox_policy = policy;
+                self.chat_widget.set_sandbox_policy(policy);
             }
         }
         Ok(true)
diff --git a/codex-rs/tui/src/bottom_pane/chat_composer.rs b/codex-rs/tui/src/bottom_pane/chat_composer.rs
index d94cd3e88e..89e31f3edc 100644
--- a/codex-rs/tui/src/bottom_pane/chat_composer.rs
+++ b/codex-rs/tui/src/bottom_pane/chat_composer.rs
@@ -1323,6 +1323,4 @@ mod tests {
             ]
         );
     }
-
-    // Esc backtracking is handled at the app layer (conversation fork); no composer test here.
 }
diff --git a/codex-rs/tui/src/bottom_pane/chat_composer_history.rs b/codex-rs/tui/src/bottom_pane/chat_composer_history.rs
index e381fc7c54..87bcc438e9 100644
--- a/codex-rs/tui/src/bottom_pane/chat_composer_history.rs
+++ b/codex-rs/tui/src/bottom_pane/chat_composer_history.rs
@@ -42,8 +42,6 @@ impl ChatComposerHistory {
         }
     }
 
-    // Removed unused reset_browsing; browsing state is reset by call sites as needed.
-
     /// Update metadata when a new session is configured.
     pub fn set_metadata(&mut self, log_id: u64, entry_count: usize) {
         self.history_log_id = Some(log_id);
diff --git a/codex-rs/tui/src/chatwidget.rs b/codex-rs/tui/src/chatwidget.rs
index dfb21dbafe..16c6e89a1d 100644
--- a/codex-rs/tui/src/chatwidget.rs
+++ b/codex-rs/tui/src/chatwidget.rs
@@ -859,8 +859,6 @@ impl ChatWidget {
         }
     }
 
-    // Removed unused render_conversation_history (handled by existing streaming path).
-
     fn request_redraw(&mut self) {
         self.frame_requester.schedule_frame();
     }