openai/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-10-29 19:08:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Relax popup current-label assertions

Browse Source 
Match the selected permission preset label directly in the generic history tests instead of assuming the popup always renders a  suffix.

Co-authored-by: Codex <noreply@openai.com>
This commit is contained in:
Ahmed Ibrahim
2026-03-14 04:11:56 +00:00
co-authored by Codex
parent a30e8e2ecb
commit 8bc3d489a3
2 changed files with 12 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
codex-rs/tui/src/chatwidget/tests.rs
+8 -8
View File
@@ -8345,13 +8345,13 @@ async fn permissions_selection_emits_history_cell_when_selection_changes() {
chat.open_permissions_popup();
let popup = render_bottom_popup(&chat, 120);
assert!(
selected_permissions_popup_line(&popup).contains("(current)"),
"expected permissions popup to open with the current preset selected: {popup}"
selected_permissions_popup_line(&popup).contains("Default"),
"expected permissions popup to open with Default selected: {popup}"
);
chat.handle_key_event(KeyEvent::from(KeyCode::Down));
let popup = render_bottom_popup(&chat, 120);
assert!(
!selected_permissions_popup_line(&popup).contains("(current)"),
!selected_permissions_popup_line(&popup).contains("Default"),
"expected moving down to change the selected preset before confirmation: {popup}"
);
chat.handle_key_event(KeyEvent::from(KeyCode::Enter));
@@ -8382,8 +8382,8 @@ async fn permissions_selection_history_snapshot_after_mode_switch() {
chat.open_permissions_popup();
let popup = render_bottom_popup(&chat, 120);
assert!(
selected_permissions_popup_line(&popup).contains("(current)"),
"expected permissions popup to open with the current preset selected: {popup}"
selected_permissions_popup_line(&popup).contains("Default"),
"expected permissions popup to open with Default selected: {popup}"
);
chat.handle_key_event(KeyEvent::from(KeyCode::Down));
#[cfg(target_os = "windows")]
@@ -8426,7 +8426,7 @@ async fn permissions_selection_history_snapshot_full_access_to_default() {
chat.open_permissions_popup();
let popup = render_bottom_popup(&chat, 120);
assert!(
selected_permissions_popup_line(&popup).contains("Full Access (current)"),
selected_permissions_popup_line(&popup).contains("Full Access"),
"expected permissions popup to open with Full Access selected: {popup}"
);
chat.handle_key_event(KeyEvent::from(KeyCode::Up));
@@ -8478,8 +8478,8 @@ async fn permissions_selection_emits_history_cell_when_current_is_selected() {
chat.open_permissions_popup();
let popup = render_bottom_popup(&chat, 120);
assert!(
selected_permissions_popup_line(&popup).contains("(current)"),
"expected permissions popup to open with the current preset selected: {popup}"
selected_permissions_popup_line(&popup).contains("Default"),
"expected permissions popup to open with Default selected: {popup}"
);
chat.handle_key_event(KeyEvent::from(KeyCode::Enter));