mirror of
https://github.com/openai/codex.git
synced 2026-11-20 22:40:37 +00:00
feat(core): enable default-mode user questions
This commit is contained in:
@@ -172,7 +172,7 @@ pub enum Feature {
|
||||
SkillEnvVarDependencyPrompt,
|
||||
/// Enable the unified mention popup prototype.
|
||||
MentionsV2,
|
||||
/// Allow request_user_input in Default collaboration mode.
|
||||
/// Removed compatibility flag; request_user_input is always available in Default mode.
|
||||
DefaultModeRequestUserInput,
|
||||
/// Enable automatic review for approval prompts.
|
||||
GuardianApproval,
|
||||
@@ -440,6 +440,9 @@ impl Features {
|
||||
"skill_env_var_dependency_prompt" => {
|
||||
continue;
|
||||
}
|
||||
"default_mode_request_user_input" => {
|
||||
continue;
|
||||
}
|
||||
"use_legacy_landlock" => {
|
||||
self.record_legacy_usage_force(
|
||||
"features.use_legacy_landlock",
|
||||
@@ -1068,7 +1071,7 @@ pub const FEATURES: &[FeatureSpec] = &[
|
||||
FeatureSpec {
|
||||
id: Feature::DefaultModeRequestUserInput,
|
||||
key: "default_mode_request_user_input",
|
||||
stage: Stage::UnderDevelopment,
|
||||
stage: Stage::Removed,
|
||||
default_enabled: false,
|
||||
},
|
||||
FeatureSpec {
|
||||
|
||||
@@ -288,6 +288,19 @@ fn js_repl_features_are_removed_feature_keys() {
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn default_mode_request_user_input_is_a_removed_feature_key() {
|
||||
assert_eq!(Feature::DefaultModeRequestUserInput.stage(), Stage::Removed);
|
||||
assert_eq!(
|
||||
Feature::DefaultModeRequestUserInput.default_enabled(),
|
||||
false
|
||||
);
|
||||
assert_eq!(
|
||||
feature_for_key("default_mode_request_user_input"),
|
||||
Some(Feature::DefaultModeRequestUserInput)
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn tool_call_mcp_elicitation_is_stable_and_enabled_by_default() {
|
||||
assert_eq!(Feature::ToolCallMcpElicitation.stage(), Stage::Stable);
|
||||
@@ -483,6 +496,25 @@ fn from_sources_ignores_removed_js_repl_feature_keys() {
|
||||
assert_eq!(features, Features::with_defaults());
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn from_sources_ignores_removed_default_mode_request_user_input_feature_key() {
|
||||
let features_toml = FeaturesToml::from(BTreeMap::from([(
|
||||
"default_mode_request_user_input".to_string(),
|
||||
true,
|
||||
)]));
|
||||
|
||||
let features = Features::from_sources(
|
||||
FeatureConfigSource {
|
||||
features: Some(&features_toml),
|
||||
..Default::default()
|
||||
},
|
||||
FeatureConfigSource::default(),
|
||||
FeatureOverrides::default(),
|
||||
);
|
||||
|
||||
assert_eq!(features, Features::with_defaults());
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn from_sources_ignores_removed_apply_patch_freeform_feature_key() {
|
||||
let features_toml =
|
||||
|
||||
Reference in New Issue
Block a user