Move service tier helpers out of data types

This commit is contained in:
Ahmed Ibrahim
2026-05-03 07:24:16 +03:00
parent e9a3e91f3c
commit 7ee21cc692
15 changed files with 109 additions and 94 deletions
@@ -12,6 +12,7 @@ use codex_app_server_protocol::ModelListResponse;
use codex_app_server_protocol::ModelUpgradeInfo;
use codex_app_server_protocol::ReasoningEffortOption;
use codex_app_server_protocol::RequestId;
use codex_protocol::config_types::is_priority_service_tier;
use codex_protocol::openai_models::ModelPreset;
use codex_protocol::openai_models::ModelServiceTier as CoreModelServiceTier;
use pretty_assertions::assert_eq;
@@ -59,7 +60,7 @@ fn model_from_preset(preset: &ModelPreset) -> Model {
fn legacy_additional_speed_tiers(service_tiers: &[CoreModelServiceTier]) -> Vec<String> {
service_tiers
.iter()
.filter_map(|tier| tier.id.is_priority().then_some("fast".to_string()))
.filter_map(|tier| is_priority_service_tier(&tier.id).then_some("fast".to_string()))
.collect()
}
@@ -340,7 +340,7 @@ async fn thread_start_accepts_flex_service_tier() -> Result<()> {
let req_id = mcp
.send_thread_start_request(ThreadStartParams {
service_tier: Some(Some(ServiceTier::flex())),
service_tier: Some(Some(ServiceTier::Flex)),
..Default::default()
})
.await?;
@@ -352,7 +352,7 @@ async fn thread_start_accepts_flex_service_tier() -> Result<()> {
.await??;
let ThreadStartResponse { service_tier, .. } = to_response::<ThreadStartResponse>(resp)?;
assert_eq!(service_tier, Some(ServiceTier::flex()));
assert_eq!(service_tier, Some(ServiceTier::Flex));
Ok(())
}