openai/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-10-27 18:48:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(app-server): gate permission confirmations by capability

Browse Source 
Add initialize-time server request capabilities so app-server only sends conversational permission confirmation requests to clients that advertise support.

Unsupported clients still fail closed without changing permissions, while capable clients receive the existing request/response flow for narrow grants and preset picker requests.
This commit is contained in:
Felipe Coury
2026-04-12 19:59:15 -03:00
parent 408a8cf02c
commit 7da6b2e850
38 changed files with 670 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files
codex-rs/app-server/src/codex_message_processor.rs
+37 -6
View File
@@ -117,6 +117,7 @@ use codex_app_server_protocol::SkillsConfigWriteParams;
use codex_app_server_protocol::SkillsConfigWriteResponse;
use codex_app_server_protocol::SkillsListParams;
use codex_app_server_protocol::SkillsListResponse;
use codex_app_server_protocol::SupportedServerRequestMethod;
use codex_app_server_protocol::Thread;
use codex_app_server_protocol::ThreadArchiveParams;
use codex_app_server_protocol::ThreadArchiveResponse;
@@ -3738,9 +3739,13 @@ impl CodexMessageProcessor {
self.thread_manager.subscribe_thread_created()
}
pub(crate) async fn connection_initialized(&self, connection_id: ConnectionId) {
pub(crate) async fn connection_initialized(
&self,
connection_id: ConnectionId,
supported_server_requests: HashSet<SupportedServerRequestMethod>,
) {
self.thread_state_manager
.connection_initialized(connection_id)
.connection_initialized(connection_id, supported_server_requests)
.await;
}
@@ -7534,11 +7539,27 @@ impl CodexMessageProcessor {
let subscribed_connection_ids = thread_state_manager
.subscribed_connection_ids(conversation_id)
.await;
let request_permissions_connection_ids = thread_state_manager
.subscribed_connection_ids_supporting(
conversation_id,
SupportedServerRequestMethod::PermissionsRequestApproval,
)
.await;
let request_permission_preset_connection_ids = thread_state_manager
.subscribed_connection_ids_supporting(
conversation_id,
SupportedServerRequestMethod::PermissionPresetRequestApproval,
)
.await;
let thread_outgoing = ThreadScopedOutgoingMessageSender::new(
outgoing_for_task.clone(),
subscribed_connection_ids,
conversation_id,
);
let request_permissions_outgoing = thread_outgoing
.with_connection_ids(request_permissions_connection_ids);
let request_permission_preset_outgoing = thread_outgoing
.with_connection_ids(request_permission_preset_connection_ids);
if let EventMsg::RawResponseItem(raw_response_item_event) = &event.msg
&& !raw_events_enabled
@@ -7560,6 +7581,8 @@ impl CodexMessageProcessor {
conversation.clone(),
thread_manager.clone(),
thread_outgoing,
request_permissions_outgoing,
request_permission_preset_outgoing,
thread_state.clone(),
thread_watch_manager.clone(),
api_version,
@@ -9917,7 +9940,9 @@ mod tests {
let connection = ConnectionId(1);
let (cancel_tx, cancel_rx) = oneshot::channel();
manager.connection_initialized(connection).await;
manager
.connection_initialized(connection, HashSet::new())
.await;
manager
.try_ensure_connection_subscribed(
thread_id, connection, /*experimental_raw_events*/ false,
@@ -9963,8 +9988,12 @@ mod tests {
let connection_b = ConnectionId(2);
let (cancel_tx, mut cancel_rx) = oneshot::channel();
manager.connection_initialized(connection_a).await;
manager.connection_initialized(connection_b).await;
manager
.connection_initialized(connection_a, HashSet::new())
.await;
manager
.connection_initialized(connection_b, HashSet::new())
.await;
manager
.try_ensure_connection_subscribed(
thread_id,
@@ -10007,7 +10036,9 @@ mod tests {
let thread_id = ThreadId::from_string("ad7f0408-99b8-4f6e-a46f-bd0eec433370")?;
let connection = ConnectionId(1);
manager.connection_initialized(connection).await;
manager
.connection_initialized(connection, HashSet::new())
.await;
let threads_to_unload = manager.remove_connection(connection).await;
assert_eq!(threads_to_unload, Vec::<ThreadId>::new());