mirror of
https://github.com/openai/codex.git
synced 2026-11-14 21:40:39 +00:00
Extend output-free transcript summaries to more tools (#60555)
## What changed - Add summary labels for MCP and dynamic tools, computer activity, terminal interactions, file edits, images, plan updates, agent calls, and historical tool fallbacks. - Keep tool output out of summaries and give summaries disclosure identities even when their cells have no activity IDs. - Bring focused disclosure headers into view and show `expand` or `collapse` in the footer, including for search-expanded entries. ## Testing Add assertions for tool labels, a transcript snapshot verifying that image-generation output stays hidden, and coverage for expanded and collapsed footer hints. GitOrigin-RevId: 076b8d74c17f26b10aa8221c65b8b38dbb5ad5ea
This commit is contained in:
@@ -1383,6 +1383,27 @@ fn parked_screen(
|
||||
text(&buf).trim_end().to_owned()
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn tool_disclosure_hides_output() {
|
||||
let image = crate::history_cell::new_image_generation_call(
|
||||
"image".into(),
|
||||
"failed",
|
||||
Some("private prompt".into()),
|
||||
/*saved_path*/ None,
|
||||
);
|
||||
let cells: &[Arc<dyn HistoryCell>] = &[Arc::new(image)];
|
||||
let mut view = TranscriptView::default();
|
||||
let collapsed = parked_screen(&mut view, cells, /*active*/ None);
|
||||
view.handle_key(KeyCode::F(4).into(), cells);
|
||||
view.handle_key(KeyCode::Enter.into(), cells);
|
||||
let expanded = parked_screen(&mut view, cells, /*active*/ None);
|
||||
insta::assert_snapshot!(format!("{collapsed}\n{expanded}"), @r"
|
||||
▸ Image generation failed
|
||||
▾ Image generation failed
|
||||
Image generation failed
|
||||
");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn live_search_group_keeps_its_summary_in_the_parked_pane() {
|
||||
use codex_app_server_protocol::CommandExecutionSource;
|
||||
|
||||
Reference in New Issue
Block a user