build: run buildifier from just fmt (#28125)

## Intent

Keep Bazel and Starlark files consistently formatted without requiring
contributors to install or version buildifier themselves.

## Implementation

- Add a SHA-256-pinned, cross-platform DotSlash manifest for buildifier
v8.5.1.
- Run buildifier from the shared `just fmt` and `just fmt-check` driver,
with Windows-safe explicit DotSlash invocation.
- Provision DotSlash in formatting CI and contributor devcontainers, and
document the source-build prerequisite.
- Apply the initial mechanical buildifier formatting baseline.
This commit is contained in:
Adam Perry @ OpenAI
2026-06-13 21:43:39 -07:00
committed by GitHub
parent 73c58011b3
commit 740c4f269d
47 changed files with 377 additions and 196 deletions

View File

@@ -145,20 +145,20 @@ cc_library(
":platform_x86_64_unknown_linux_musl": ["ANDROID_HOST_MUSL"],
"//conditions:default": [],
}),
visibility = ["//visibility:public"],
deps = [
"@rusty_v8_libcxx//:headers",
"@rusty_v8_libcxxabi//:headers",
],
visibility = ["//visibility:public"],
)
cc_library(
name = "rusty_v8_custom_libcxx_runtime",
visibility = ["//visibility:public"],
deps = [
"@rusty_v8_libcxx//:libcxx",
"@rusty_v8_libcxxabi//:libcxxabi",
],
visibility = ["//visibility:public"],
)
genrule(
@@ -262,44 +262,44 @@ cc_library(
cc_static_library(
name = "v8_146_4_0_aarch64_apple_darwin_bazel",
deps = [":v8_146_4_0_binding"],
features = V8_STATIC_LIBRARY_FEATURES,
deps = [":v8_146_4_0_binding"],
)
cc_static_library(
name = "v8_146_4_0_aarch64_unknown_linux_gnu_bazel",
deps = [":v8_146_4_0_binding"],
features = V8_STATIC_LIBRARY_FEATURES,
deps = [":v8_146_4_0_binding"],
)
cc_static_library(
name = "v8_146_4_0_aarch64_pc_windows_gnullvm_bazel",
deps = [":v8_146_4_0_binding"],
features = V8_STATIC_LIBRARY_FEATURES,
deps = [":v8_146_4_0_binding"],
)
cc_static_library(
name = "v8_146_4_0_x86_64_apple_darwin_bazel",
deps = [":v8_146_4_0_binding"],
features = V8_STATIC_LIBRARY_FEATURES,
deps = [":v8_146_4_0_binding"],
)
cc_static_library(
name = "v8_146_4_0_x86_64_pc_windows_gnullvm_bazel",
deps = [":v8_146_4_0_binding"],
features = V8_STATIC_LIBRARY_FEATURES,
deps = [":v8_146_4_0_binding"],
)
cc_static_library(
name = "v8_146_4_0_x86_64_unknown_linux_gnu_bazel",
deps = [":v8_146_4_0_binding"],
features = V8_STATIC_LIBRARY_FEATURES,
deps = [":v8_146_4_0_binding"],
)
cc_static_library(
name = "v8_146_4_0_aarch64_unknown_linux_musl_release_base",
deps = [":v8_146_4_0_binding"],
features = V8_STATIC_LIBRARY_FEATURES,
deps = [":v8_146_4_0_binding"],
)
genrule(
@@ -308,10 +308,6 @@ genrule(
":v8_146_4_0_aarch64_unknown_linux_musl_release_base",
"@llvm//runtimes/compiler-rt:clang_rt.builtins.static",
],
tools = [
"@llvm//tools:llvm-ar",
"@llvm//tools:llvm-ranlib",
],
outs = ["libv8_146_4_0_aarch64_unknown_linux_musl.a"],
cmd = """
cat > "$(@D)/merge.mri" <<'EOF'
@@ -324,12 +320,16 @@ EOF
$(location @llvm//tools:llvm-ar) -M < "$(@D)/merge.mri"
$(location @llvm//tools:llvm-ranlib) "$@"
""",
tools = [
"@llvm//tools:llvm-ar",
"@llvm//tools:llvm-ranlib",
],
)
cc_static_library(
name = "v8_146_4_0_x86_64_unknown_linux_musl_release",
deps = [":v8_146_4_0_binding"],
features = V8_STATIC_LIBRARY_FEATURES,
deps = [":v8_146_4_0_binding"],
)
filegroup(
@@ -344,35 +344,35 @@ filegroup(
cc_static_library(
name = "v8_149_2_0_aarch64_apple_darwin_bazel",
features = V8_STATIC_LIBRARY_FEATURES,
deps = [
":rusty_v8_custom_libcxx_runtime",
":v8_149_2_0_binding",
],
features = V8_STATIC_LIBRARY_FEATURES,
)
cc_static_library(
name = "v8_149_2_0_aarch64_unknown_linux_gnu_bazel",
features = V8_STATIC_LIBRARY_FEATURES,
deps = [
":rusty_v8_custom_libcxx_runtime",
":v8_149_2_0_binding",
],
features = V8_STATIC_LIBRARY_FEATURES,
)
cc_static_library(
name = "v8_149_2_0_aarch64_pc_windows_gnullvm_bazel",
deps = [":v8_149_2_0_binding"],
features = V8_STATIC_LIBRARY_FEATURES,
deps = [":v8_149_2_0_binding"],
)
cc_static_library(
name = "v8_149_2_0_aarch64_unknown_linux_musl_release_base",
features = V8_STATIC_LIBRARY_FEATURES,
deps = [
":rusty_v8_custom_libcxx_runtime",
":v8_149_2_0_binding",
],
features = V8_STATIC_LIBRARY_FEATURES,
)
genrule(
@@ -381,10 +381,6 @@ genrule(
":v8_149_2_0_aarch64_unknown_linux_musl_release_base",
"@llvm//runtimes/compiler-rt:clang_rt.builtins.static",
],
tools = [
"@llvm//tools:llvm-ar",
"@llvm//tools:llvm-ranlib",
],
outs = ["libv8_149_2_0_aarch64_unknown_linux_musl.a"],
cmd = """
cat > "$(@D)/merge.mri" <<'EOF'
@@ -397,39 +393,43 @@ EOF
$(location @llvm//tools:llvm-ar) -M < "$(@D)/merge.mri"
$(location @llvm//tools:llvm-ranlib) "$@"
""",
tools = [
"@llvm//tools:llvm-ar",
"@llvm//tools:llvm-ranlib",
],
)
cc_static_library(
name = "v8_149_2_0_x86_64_apple_darwin_bazel",
features = V8_STATIC_LIBRARY_FEATURES,
deps = [
":rusty_v8_custom_libcxx_runtime",
":v8_149_2_0_binding",
],
features = V8_STATIC_LIBRARY_FEATURES,
)
cc_static_library(
name = "v8_149_2_0_x86_64_unknown_linux_gnu_bazel",
features = V8_STATIC_LIBRARY_FEATURES,
deps = [
":rusty_v8_custom_libcxx_runtime",
":v8_149_2_0_binding",
],
features = V8_STATIC_LIBRARY_FEATURES,
)
cc_static_library(
name = "v8_149_2_0_x86_64_pc_windows_gnullvm_bazel",
deps = [":v8_149_2_0_binding"],
features = V8_STATIC_LIBRARY_FEATURES,
deps = [":v8_149_2_0_binding"],
)
cc_static_library(
name = "v8_149_2_0_x86_64_unknown_linux_musl_release",
features = V8_STATIC_LIBRARY_FEATURES,
deps = [
":rusty_v8_custom_libcxx_runtime",
":v8_149_2_0_binding",
],
features = V8_STATIC_LIBRARY_FEATURES,
)
filegroup(
@@ -475,111 +475,111 @@ filegroup(
filegroup(
name = "rusty_v8_release_pair_x86_64_apple_darwin",
srcs = [
":v8_149_2_0_x86_64_apple_darwin_bazel",
":src_binding_release_x86_64_apple_darwin_149_2_0_release",
":v8_149_2_0_x86_64_apple_darwin_bazel",
],
)
filegroup(
name = "rusty_v8_release_pair_aarch64_apple_darwin",
srcs = [
":v8_149_2_0_aarch64_apple_darwin_bazel",
":src_binding_release_aarch64_apple_darwin_149_2_0_release",
":v8_149_2_0_aarch64_apple_darwin_bazel",
],
)
filegroup(
name = "rusty_v8_release_pair_x86_64_unknown_linux_gnu",
srcs = [
":v8_149_2_0_x86_64_unknown_linux_gnu_bazel",
":src_binding_release_x86_64_unknown_linux_gnu_149_2_0_release",
":v8_149_2_0_x86_64_unknown_linux_gnu_bazel",
],
)
filegroup(
name = "rusty_v8_release_pair_aarch64_unknown_linux_gnu",
srcs = [
":v8_149_2_0_aarch64_unknown_linux_gnu_bazel",
":src_binding_release_aarch64_unknown_linux_gnu_149_2_0_release",
":v8_149_2_0_aarch64_unknown_linux_gnu_bazel",
],
)
filegroup(
name = "rusty_v8_release_pair_x86_64_unknown_linux_musl",
srcs = [
":v8_149_2_0_x86_64_unknown_linux_musl_release",
":src_binding_release_x86_64_unknown_linux_musl_149_2_0_release",
":v8_149_2_0_x86_64_unknown_linux_musl_release",
],
)
filegroup(
name = "rusty_v8_release_pair_aarch64_unknown_linux_musl",
srcs = [
":v8_149_2_0_aarch64_unknown_linux_musl_release",
":src_binding_release_aarch64_unknown_linux_musl_149_2_0_release",
":v8_149_2_0_aarch64_unknown_linux_musl_release",
],
)
filegroup(
name = "rusty_v8_release_pair_x86_64_pc_windows_msvc",
srcs = [
":v8_149_2_0_x86_64_pc_windows_msvc",
":src_binding_release_x86_64_pc_windows_msvc_149_2_0_release",
":v8_149_2_0_x86_64_pc_windows_msvc",
],
)
filegroup(
name = "rusty_v8_release_pair_aarch64_pc_windows_msvc",
srcs = [
":v8_149_2_0_aarch64_pc_windows_msvc",
":src_binding_release_aarch64_pc_windows_msvc_149_2_0_release",
":v8_149_2_0_aarch64_pc_windows_msvc",
],
)
filegroup(
name = "rusty_v8_sandbox_release_pair_x86_64_apple_darwin",
srcs = [
":v8_149_2_0_x86_64_apple_darwin_bazel",
":src_binding_release_x86_64_apple_darwin_149_2_0_release",
":v8_149_2_0_x86_64_apple_darwin_bazel",
],
)
filegroup(
name = "rusty_v8_sandbox_release_pair_aarch64_apple_darwin",
srcs = [
":v8_149_2_0_aarch64_apple_darwin_bazel",
":src_binding_release_aarch64_apple_darwin_149_2_0_release",
":v8_149_2_0_aarch64_apple_darwin_bazel",
],
)
filegroup(
name = "rusty_v8_sandbox_release_pair_x86_64_unknown_linux_gnu",
srcs = [
":v8_149_2_0_x86_64_unknown_linux_gnu_bazel",
":src_binding_release_x86_64_unknown_linux_gnu_149_2_0_release",
":v8_149_2_0_x86_64_unknown_linux_gnu_bazel",
],
)
filegroup(
name = "rusty_v8_sandbox_release_pair_aarch64_unknown_linux_gnu",
srcs = [
":v8_149_2_0_aarch64_unknown_linux_gnu_bazel",
":src_binding_release_aarch64_unknown_linux_gnu_149_2_0_release",
":v8_149_2_0_aarch64_unknown_linux_gnu_bazel",
],
)
filegroup(
name = "rusty_v8_sandbox_release_pair_x86_64_unknown_linux_musl",
srcs = [
":v8_149_2_0_x86_64_unknown_linux_musl_release",
":src_binding_release_x86_64_unknown_linux_musl_149_2_0_release",
":v8_149_2_0_x86_64_unknown_linux_musl_release",
],
)
filegroup(
name = "rusty_v8_sandbox_release_pair_aarch64_unknown_linux_musl",
srcs = [
":v8_149_2_0_aarch64_unknown_linux_musl_release",
":src_binding_release_aarch64_unknown_linux_musl_149_2_0_release",
":v8_149_2_0_aarch64_unknown_linux_musl_release",
],
)

View File

@@ -1,5 +1,5 @@
load("@rules_cc//cc:defs.bzl", "cc_library")
load("@llvm//toolchain/runtimes:cc_runtime_library.bzl", "cc_runtime_stage0_library")
load("@rules_cc//cc:defs.bzl", "cc_library")
package(default_visibility = ["//visibility:public"])
@@ -135,7 +135,6 @@ cc_runtime_stage0_library(
],
"//conditions:default": [],
}),
includes = ["src"],
implementation_deps = [
":headers",
":internal_headers",
@@ -155,4 +154,5 @@ cc_runtime_stage0_library(
],
"//conditions:default": [],
}),
includes = ["src"],
)

View File

@@ -1,5 +1,5 @@
load("@rules_cc//cc:defs.bzl", "cc_library")
load("@llvm//toolchain/runtimes:cc_runtime_library.bzl", "cc_runtime_stage0_library")
load("@rules_cc//cc:defs.bzl", "cc_library")
package(default_visibility = ["//visibility:public"])
@@ -42,11 +42,6 @@ cc_runtime_stage0_library(
":is_linux": ["src/cxa_thread_atexit.cpp"],
"//conditions:default": [],
}),
textual_hdrs = glob([
"src/**/*.def",
"src/**/*.h",
"src/**/*.inc",
]),
copts = [
"-fexceptions",
"-frtti",
@@ -76,12 +71,11 @@ cc_runtime_stage0_library(
],
"//conditions:default": [],
}),
includes = ["src"],
implementation_deps = [
":headers",
"@//third_party/v8/libcxx_config:headers",
"@rusty_v8_libcxx//:headers",
"@rusty_v8_libcxx//:internal_headers",
"@//third_party/v8/libcxx_config:headers",
] + select({
":is_linux": [
"@@llvm++kernel_headers+kernel_headers//:kernel_headers",
@@ -96,4 +90,10 @@ cc_runtime_stage0_library(
],
"//conditions:default": [],
}),
includes = ["src"],
textual_hdrs = glob([
"src/**/*.def",
"src/**/*.h",
"src/**/*.inc",
]),
)