mirror of
https://github.com/openai/codex.git
synced 2026-11-15 21:50:46 +00:00
Use app-server state for TUI Windows sandbox decisions (#45821)
## Why Windows sandbox setup and permission choices need to reflect the connected app server's requirements and the active thread's executors. ## What changed - Refresh sandbox configuration and requirements for the current working directory when threads or directories change, before setup, and after setup completes. - Use the thread's observed environments to determine whether sandbox setup is local, remote, mixed, or unknown. - Defer initial prompt submission while requirements load and preserve the draft if loading fails or required setup is unavailable. - Hide sandbox setup choices and elevation commands that requirements or executor selection disallow. ## Testing Add coverage for observed thread hosts, app-server configuration reads, draft preservation and recovery after read failures, deferred initial prompts, and non-admin-only setup choices. GitOrigin-RevId: d85ac66d18951b752e71d1a6bf25404eeedcad02
This commit is contained in:
@@ -137,7 +137,9 @@ impl ChatWidget {
|
||||
snapshot_local_images: false,
|
||||
pending_image_submission: None,
|
||||
local_worktree_operations: true,
|
||||
windows_sandbox_host: crate::app::WindowsSandboxHost::Local,
|
||||
windows_sandbox_local_server: false,
|
||||
windows_sandbox_config: Default::default(),
|
||||
windows_sandbox_host: crate::app::WindowsSandboxHost::Unknown,
|
||||
#[cfg(any(target_os = "windows", test))]
|
||||
windows_sandbox_elevated_setup_complete: false,
|
||||
token_info: None,
|
||||
@@ -303,13 +305,6 @@ impl ChatWidget {
|
||||
widget
|
||||
.bottom_pane
|
||||
.set_queued_message_edit_binding(widget.queued_message_edit_hint_binding);
|
||||
#[cfg(target_os = "windows")]
|
||||
widget
|
||||
.bottom_pane
|
||||
.set_windows_degraded_sandbox_active(matches!(
|
||||
crate::windows_sandbox::level_from_config(&widget.config),
|
||||
WindowsSandboxLevel::RestrictedToken
|
||||
));
|
||||
widget.update_collaboration_mode_indicator();
|
||||
|
||||
widget
|
||||
|
||||
Reference in New Issue
Block a user