mirror of
https://github.com/openai/codex.git
synced 2026-11-15 21:50:46 +00:00
Record sandbox backends in command execution analytics (#47568)
## Why Command execution analytics lack the observed sandbox backend. Older execution servers may omit this information, so an unknown backend must remain distinguishable from an explicitly unsandboxed process. ## What changed - Carry optional `sandbox_type` metadata through command execution items and emit its metric tag as `sandbox_backend` in analytics. - Propagate the observed backend through unified execution completion and failure events, including asynchronous exits. - Preserve missing backend information as `None` and mark executed user shell commands as `Some(SandboxType::None)`. - Exclude the metadata from serialized command items and generated schemas and TypeScript types. ## Testing Extend tests for missing and explicit executor backends, backend propagation on failed execution, and analytics payloads, including platform-specific backend tags in app-server integration coverage. GitOrigin-RevId: 178fe46824a6194910802ec02168ed40ee0b2019
This commit is contained in:
@@ -1422,6 +1422,7 @@ async fn start_command_execution_item(
|
||||
item: ThreadItem::CommandExecution {
|
||||
id: item_id,
|
||||
model_context,
|
||||
sandbox_type: None,
|
||||
plugin_id,
|
||||
script_path,
|
||||
command,
|
||||
@@ -1467,6 +1468,7 @@ async fn complete_command_execution_item(
|
||||
let item = ThreadItem::CommandExecution {
|
||||
id: item_id,
|
||||
model_context: completion_item.model_context,
|
||||
sandbox_type: None,
|
||||
plugin_id: completion_item.plugin_id,
|
||||
script_path: completion_item.script_path,
|
||||
command: completion_item.command,
|
||||
@@ -2484,6 +2486,7 @@ mod tests {
|
||||
payload.item,
|
||||
ThreadItem::CommandExecution {
|
||||
model_context: None,
|
||||
sandbox_type: None,
|
||||
id: "cmd-1".to_string(),
|
||||
plugin_id: completion_item.plugin_id.clone(),
|
||||
script_path: completion_item.script_path.clone(),
|
||||
|
||||
Reference in New Issue
Block a user