mirror of
https://github.com/openai/codex.git
synced 2026-11-16 22:00:36 +00:00
Refresh cloud plugin and skill catalogs during step preparation (#61429)
## Why Installing a plugin without connector tools must still refresh a cached cloud skill catalog so its skills are visible to the next inference. ## What changed - Rely on step preparation for cloud plugin and skill discovery, removing their turn-start callbacks and the `requires_mcp_runtime` lifecycle hook. - Request an MCP runtime refresh after every completed plugin install, including skills-only installs. ## Testing Add regression coverage for skills becoming visible immediately after a connector-free install. Update lifecycle tests to cover discovery after MCP reconciliation, prewarm skipping discovery, cancellation allowing subsequent preparation, and reuse of unchanged connections. Use deterministic DNS lookups in network proxy authorization tests. GitOrigin-RevId: 76036bd29253fb8987e606c3c28411c689590fc4
This commit is contained in:
committed by
copyberry
parent
005f910210
commit
6d919e65e2
@@ -1897,7 +1897,13 @@ mod tests {
|
||||
|
||||
assert_eq!(
|
||||
state
|
||||
.host_blocked("api.openai.com", /*port*/ 80)
|
||||
.host_blocked_with_lookup(
|
||||
"api.openai.com",
|
||||
/*port*/ 80,
|
||||
/*allow_local_binding*/ None,
|
||||
HostAuthorization::RequireAllowlist,
|
||||
|_host, port| async move { Ok(vec![SocketAddr::from(([8, 8, 8, 8], port))]) },
|
||||
)
|
||||
.await
|
||||
.unwrap(),
|
||||
HostBlockDecision::Allowed
|
||||
@@ -1914,14 +1920,26 @@ mod tests {
|
||||
|
||||
assert_eq!(
|
||||
state
|
||||
.host_blocked("example.com", /*port*/ 80)
|
||||
.host_blocked_with_lookup(
|
||||
"example.com",
|
||||
/*port*/ 80,
|
||||
/*allow_local_binding*/ None,
|
||||
HostAuthorization::RequireAllowlist,
|
||||
|_host, port| async move { Ok(vec![SocketAddr::from(([8, 8, 8, 8], port))]) },
|
||||
)
|
||||
.await
|
||||
.unwrap(),
|
||||
HostBlockDecision::Allowed
|
||||
);
|
||||
assert_eq!(
|
||||
state
|
||||
.host_blocked("api.openai.com", /*port*/ 443)
|
||||
.host_blocked_with_lookup(
|
||||
"api.openai.com",
|
||||
/*port*/ 443,
|
||||
/*allow_local_binding*/ None,
|
||||
HostAuthorization::RequireAllowlist,
|
||||
|_host, port| async move { Ok(vec![SocketAddr::from(([8, 8, 8, 8], port))]) },
|
||||
)
|
||||
.await
|
||||
.unwrap(),
|
||||
HostBlockDecision::Allowed
|
||||
|
||||
@@ -1077,6 +1077,7 @@ mod tests {
|
||||
mode: NetworkMode::Full,
|
||||
mitm: true,
|
||||
credential_broker: true,
|
||||
// This test exercises protocol detection, independently of live DNS resolution.
|
||||
allow_local_binding: Some(true),
|
||||
..NetworkProxyConfig::default()
|
||||
};
|
||||
|
||||
Reference in New Issue
Block a user