mirror of
https://github.com/openai/codex.git
synced 2026-11-18 22:20:48 +00:00
Snapshot resolved settings for each model step (#40651)
## Why Thread settings can change while a turn is running, and delegated review or compaction steps can select a different model. Each request needs a consistent set of settings resolved against the model that will execute it. ## What changed - Capture immutable resolved settings for each model step, including model metadata, reasoning options, service tier, approvals, and personality. - Keep in-flight steps on their captured settings while applying thread updates to subsequent work. - Resolve inherited reasoning summaries and filter service tiers against the selected model and feature configuration for review and compaction steps. ## Testing Added coverage for settings updates during paused turns, model changes, previous-model compaction, review-model defaults, and service-tier filtering. GitOrigin-RevId: fca4b3b305379f1bf26a5cac75ee0dd1747ac1f6
This commit is contained in:
committed by
copyberry
parent
ba6cf9c692
commit
68301fa45f
@@ -58,7 +58,7 @@ pub(super) async fn run_remote_compact_attempt(
|
||||
let trace_input_history = compaction_trace
|
||||
.is_enabled()
|
||||
.then(|| history.raw_items().cloned().collect());
|
||||
let prompt_input = history.for_prompt(&turn_context.model_info.input_modalities);
|
||||
let prompt_input = history.for_prompt(&turn_context.model_info().input_modalities);
|
||||
let tool_router = &step_context.tool_router;
|
||||
let prompt = Prompt {
|
||||
input: prompt_input,
|
||||
@@ -79,11 +79,11 @@ pub(super) async fn run_remote_compact_attempt(
|
||||
.model_client
|
||||
.compact_conversation_history(
|
||||
&prompt,
|
||||
&turn_context.model_info,
|
||||
turn_context.model_info(),
|
||||
turn_state,
|
||||
CompactConversationRequestSettings {
|
||||
effort: turn_context.reasoning_effort.clone(),
|
||||
summary: turn_context.reasoning_summary,
|
||||
effort: turn_context.reasoning_effort().cloned(),
|
||||
summary: turn_context.reasoning_summary(),
|
||||
service_tier: if sess.services.auth_manager.auth_mode() == Some(AuthMode::ApiKey) {
|
||||
None
|
||||
} else {
|
||||
|
||||
Reference in New Issue
Block a user