mirror of
https://github.com/openai/codex.git
synced 2026-11-20 22:40:37 +00:00
Stream app-server fs/readFile responses over stdio (#62599)
## Why Large file reads over stdio previously allocated both a base64 string and a complete JSON response before writing to stdout. ## What changed Keep file contents as bytes until the stdio writer encodes them directly into the newline-delimited JSON response through a bounded buffer. Clients still receive the same `dataBase64` field. ## Testing Compare streamed output byte for byte with the eagerly encoded response for empty files, inputs that require base64 padding, and files larger than the write buffer. Check that JSON-RPC conversion preserves the request ID and base64 payload. GitOrigin-RevId: 730f201f0905fd15e32b6e9c5b2ef02ca21c7532
This commit is contained in:
@@ -1360,11 +1360,18 @@ impl MessageProcessor {
|
||||
ClientRequest::EnvironmentStatus { params, .. } => {
|
||||
self.environment_processor.environment_status(params).await
|
||||
}
|
||||
ClientRequest::FsReadFile { params, .. } => self
|
||||
.fs_processor
|
||||
.read_file(params)
|
||||
.await
|
||||
.map(|response| Some(response.into())),
|
||||
ClientRequest::FsReadFile { params, .. } => {
|
||||
self.fs_processor.read_file(params).await.map(|file| {
|
||||
// Defer encoding to the stdio writer. Remote control serializes
|
||||
// for both segment sizing and transmission.
|
||||
let payload = if session.origin == crate::transport::ConnectionOrigin::Stdio {
|
||||
ClientResponsePayload::FsReadFileBytes(file)
|
||||
} else {
|
||||
ClientResponsePayload::FsReadFile(file.into())
|
||||
};
|
||||
Some(payload)
|
||||
})
|
||||
}
|
||||
ClientRequest::FsWriteFile { params, .. } => self
|
||||
.fs_processor
|
||||
.write_file(params)
|
||||
|
||||
Reference in New Issue
Block a user