From 28552715bad3a10a88d6fe252c4566679617b617 Mon Sep 17 00:00:00 2001 From: viyatb-oai Date: Thu, 16 Apr 2026 16:53:08 -0700 Subject: [PATCH 1/2] fix: use existing app-server connection id Co-authored-by: Codex noreply@openai.com --- codex-rs/app-server/src/message_processor.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/codex-rs/app-server/src/message_processor.rs b/codex-rs/app-server/src/message_processor.rs index 5a443c6820..6221cebee5 100644 --- a/codex-rs/app-server/src/message_processor.rs +++ b/codex-rs/app-server/src/message_processor.rs @@ -752,7 +752,7 @@ impl MessageProcessor { | ClientRequest::TurnSteer { request_id, .. } = &codex_request { self.analytics_events_client.track_request( - connection_request_id.connection_id.0, + connection_id.0, request_id.clone(), codex_request.clone(), ); From 4982c9751ff444554479d59abb1697a5e2b94e1e Mon Sep 17 00:00:00 2001 From: viyatb-oai Date: Thu, 16 Apr 2026 16:55:29 -0700 Subject: [PATCH 2/2] fix: make hook precedence tests portable Co-authored-by: Codex noreply@openai.com --- codex-rs/Cargo.lock | 1 - codex-rs/hooks/Cargo.toml | 1 - codex-rs/hooks/src/events/session_start.rs | 8 ++++---- codex-rs/hooks/src/events/user_prompt_submit.rs | 8 ++++---- 4 files changed, 8 insertions(+), 10 deletions(-) diff --git a/codex-rs/Cargo.lock b/codex-rs/Cargo.lock index 0af621faa6..bd74d83ad6 100644 --- a/codex-rs/Cargo.lock +++ b/codex-rs/Cargo.lock @@ -2284,7 +2284,6 @@ version = "0.0.0" dependencies = [ "anyhow", "chrono", - "codex-app-server-protocol", "codex-config", "codex-protocol", "codex-utils-absolute-path", diff --git a/codex-rs/hooks/Cargo.toml b/codex-rs/hooks/Cargo.toml index fb25c15e39..d4d2f9cbc7 100644 --- a/codex-rs/hooks/Cargo.toml +++ b/codex-rs/hooks/Cargo.toml @@ -15,7 +15,6 @@ workspace = true [dependencies] anyhow = { workspace = true } chrono = { workspace = true, features = ["serde"] } -codex-app-server-protocol = { workspace = true } codex-config = { workspace = true } codex-protocol = { workspace = true } codex-utils-absolute-path = { workspace = true } diff --git a/codex-rs/hooks/src/events/session_start.rs b/codex-rs/hooks/src/events/session_start.rs index 7e3071ef83..197234dae5 100644 --- a/codex-rs/hooks/src/events/session_start.rs +++ b/codex-rs/hooks/src/events/session_start.rs @@ -397,15 +397,15 @@ mod tests { ( "cmd.exe".to_string(), vec!["/D".to_string(), "/C".to_string()], - r#"echo {^"continue^":false,^"stopReason^":^"pause^",^"hookSpecificOutput^":{^"hookEventName^":^"SessionStart^",^"additionalContext^":^"trusted context^"}}"#.to_string(), - "type nul > project-ran && echo project context".to_string(), + r#"more > nul && echo {^"continue^":false,^"stopReason^":^"pause^",^"hookSpecificOutput^":{^"hookEventName^":^"SessionStart^",^"additionalContext^":^"trusted context^"}}"#.to_string(), + "more > nul && type nul > project-ran && echo project context".to_string(), ) } else { ( "/bin/sh".to_string(), vec!["-c".to_string()], - "printf '%s' '{\"continue\":false,\"stopReason\":\"pause\",\"hookSpecificOutput\":{\"hookEventName\":\"SessionStart\",\"additionalContext\":\"trusted context\"}}'".to_string(), - "touch project-ran && printf 'project context'".to_string(), + "cat >/dev/null; printf '%s' '{\"continue\":false,\"stopReason\":\"pause\",\"hookSpecificOutput\":{\"hookEventName\":\"SessionStart\",\"additionalContext\":\"trusted context\"}}'".to_string(), + "cat >/dev/null; touch project-ran && printf 'project context'".to_string(), ) }; let handlers = vec![ diff --git a/codex-rs/hooks/src/events/user_prompt_submit.rs b/codex-rs/hooks/src/events/user_prompt_submit.rs index 275530e35f..9596aae848 100644 --- a/codex-rs/hooks/src/events/user_prompt_submit.rs +++ b/codex-rs/hooks/src/events/user_prompt_submit.rs @@ -454,15 +454,15 @@ mod tests { ( "cmd.exe".to_string(), vec!["/D".to_string(), "/C".to_string()], - r#"echo {^"decision^":^"block^",^"reason^":^"slow down^",^"hookSpecificOutput^":{^"hookEventName^":^"UserPromptSubmit^",^"additionalContext^":^"trusted context^"}}"#.to_string(), - "type nul > project-ran && echo project context".to_string(), + r#"more > nul && echo {^"decision^":^"block^",^"reason^":^"slow down^",^"hookSpecificOutput^":{^"hookEventName^":^"UserPromptSubmit^",^"additionalContext^":^"trusted context^"}}"#.to_string(), + "more > nul && type nul > project-ran && echo project context".to_string(), ) } else { ( "/bin/sh".to_string(), vec!["-c".to_string()], - "printf '%s' '{\"decision\":\"block\",\"reason\":\"slow down\",\"hookSpecificOutput\":{\"hookEventName\":\"UserPromptSubmit\",\"additionalContext\":\"trusted context\"}}'".to_string(), - "touch project-ran && printf 'project context'".to_string(), + "cat >/dev/null; printf '%s' '{\"decision\":\"block\",\"reason\":\"slow down\",\"hookSpecificOutput\":{\"hookEventName\":\"UserPromptSubmit\",\"additionalContext\":\"trusted context\"}}'".to_string(), + "cat >/dev/null; touch project-ran && printf 'project context'".to_string(), ) }; let handlers = vec![