Preserve output from hooks that exit before reading stdin (#35194)

## Why

A hook can exit successfully without consuming its JSON input. If it closes
stdin while Codex is still writing, the resulting broken pipe should not hide
the hook's exit status and output.

## What changed

Ignore broken-pipe errors when writing hook stdin and continue waiting for the
process result. Other stdin write errors remain failures.

## Testing

Add a cross-platform regression test that sends a large input to a
fast-exiting hook and verifies that its successful status and stdout are
preserved.

GitOrigin-RevId: e1b6e7c6ac5e39232e49b45245ea0df9d34d1fe6
This commit is contained in:
jif
2026-07-24 14:37:11 +00:00
committed by copyberry
parent 7c71783135
commit 634a998d8a
2 changed files with 42 additions and 1 deletions
+3 -1
View File
@@ -1,3 +1,4 @@
use std::io::ErrorKind;
use std::path::Path;
use std::process::Stdio;
use std::time::Duration;
@@ -83,6 +84,7 @@ pub(crate) async fn run_command(
if let Some(mut stdin) = child.stdin.take()
&& let Err(err) = stdin.write_all(input_json.as_bytes()).await
&& err.kind() != ErrorKind::BrokenPipe
{
let _ = child.kill().await;
return finish_command_run(
@@ -208,6 +210,6 @@ fn default_shell_command() -> Command {
}
}
#[cfg(all(test, windows))]
#[cfg(test)]
#[path = "command_runner_tests.rs"]
mod tests;