From 61b08f101142f02e0f79e62be601a3b96a3415d0 Mon Sep 17 00:00:00 2001 From: Celia Chen Date: Fri, 18 Sep 2026 18:22:11 +0000 Subject: [PATCH] Disable reasoning summaries by default for new TUI threads (#46533) ## What changed Default `model_reasoning_summary` to `none` instead of `detailed` when starting a new TUI thread, while preserving explicit settings. Enabling `features.concurrent_reasoning_summaries` alone no longer enables summaries. ## Testing Update thread configuration and embedded app-server request tests to cover the disabled default, explicit summary settings, and concurrent summary delivery. GitOrigin-RevId: 16b0711d92c28944afd6bc85d44a9de0282a6533 --- codex-rs/tui/src/app_server_session.rs | 2 +- .../reasoning_defaults_tests.rs | 25 ++++++++++++++++--- 2 files changed, 22 insertions(+), 5 deletions(-) diff --git a/codex-rs/tui/src/app_server_session.rs b/codex-rs/tui/src/app_server_session.rs index 0280628e29..ee6e92666f 100644 --- a/codex-rs/tui/src/app_server_session.rs +++ b/codex-rs/tui/src/app_server_session.rs @@ -1944,7 +1944,7 @@ fn new_thread_reasoning_overrides(config: &Config) -> Option Result<()> { for (settings, summary, stream_options) in [ - ("", json!("detailed"), json!(null)), + ("", json!(null), json!(null)), ( "[features]\nconcurrent_reasoning_summaries = false", - json!("detailed"), + json!(null), json!(null), ), ( "[features]\nconcurrent_reasoning_summaries = true", + json!(null), + json!(null), + ), + ( + "model_reasoning_summary = 'detailed'", + json!("detailed"), + json!(null), + ), + ( + "model_reasoning_summary = 'detailed'\n[features]\nconcurrent_reasoning_summaries = true", json!("detailed"), json!({"reasoning_summary_delivery": "sequential_cutoff"}), ), @@ -102,12 +112,19 @@ stream_max_retries = 0 } #[tokio::test] -async fn new_tui_threads_request_summaries_unless_explicitly_disabled() { +async fn new_tui_threads_disable_summaries_unless_explicitly_enabled() { let temp_dir = tempfile::tempdir().expect("tempdir"); for (config_text, expected_summary, expected_concurrent) in [ - ("", "detailed", false), + ("", "none", false), ( "[features]\nconcurrent_reasoning_summaries = true", + "none", + false, + ), + ("model_reasoning_summary = 'auto'", "auto", false), + ("model_reasoning_summary = 'detailed'", "detailed", false), + ( + "model_reasoning_summary = 'detailed'\n[features]\nconcurrent_reasoning_summaries = true", "detailed", true, ),