mirror of
https://github.com/openai/codex.git
synced 2026-11-21 22:50:37 +00:00
Tag user reports with the latest reasoning removal status (#62883)
## What changed Set the `cot_removed` tag from the latest completed sampling request on the live thread. Use `true` for reported reasoning removals and `false` for an explicitly empty report. Omit the tag when no report is available and discard any caller-supplied value. Clear the stored result when thread history is replaced. A resumed session starts without a stored result. ## Testing Cover tag values in saved reports across tool calls, compaction, and session resume. Verify that failed compaction preserves the last sampling result. GitOrigin-RevId: f1568567a6b4a62685569478fc7194f4357cb605
This commit is contained in:
@@ -128,6 +128,13 @@ impl FeedbackRequestProcessor {
|
||||
|
||||
let http_client_factory = self.config.http_client_factory();
|
||||
let auth = self.auth_manager.auth_cached();
|
||||
upload_tags.remove("cot_removed");
|
||||
if let Some(id) = conversation_id
|
||||
&& let Ok(thread) = self.thread_manager.get_thread(id).await
|
||||
&& let Some(removed) = thread.last_sampling_cot_removed().await
|
||||
{
|
||||
upload_tags.insert("cot_removed".to_string(), removed.to_string());
|
||||
}
|
||||
let turn_metadata = if let Some(conversation_id) = conversation_id
|
||||
&& let Some(rollout_path) = self
|
||||
.resolve_rollout_path(conversation_id, self.state_db.as_ref(), save_path.as_ref())
|
||||
|
||||
Reference in New Issue
Block a user