add manual tool execution mode

Co-authored-by: Codex <noreply@openai.com>
This commit is contained in:
ashwinnathan-openai
2026-03-16 18:13:35 -07:00
co-authored by Codex
parent b77fe8fefe
commit 5cc05f66aa
25 changed files with 450 additions and 6 deletions
@@ -19,6 +19,7 @@ use codex_app_server_protocol::JSONRPCResponse;
use codex_app_server_protocol::MergeStrategy;
use codex_app_server_protocol::RequestId;
use codex_app_server_protocol::SandboxMode;
use codex_app_server_protocol::ToolExecutionMode;
use codex_app_server_protocol::ToolsV2;
use codex_app_server_protocol::WriteStatus;
use codex_core::config::set_project_trust_level;
@@ -102,6 +103,7 @@ allowed_domains = ["example.com"]
[tools]
view_image = false
execution_mode = "manual"
"#,
)?;
let codex_home_path = codex_home.path().canonicalize()?;
@@ -137,6 +139,7 @@ view_image = false
location: None,
}),
view_image: Some(false),
execution_mode: Some(ToolExecutionMode::Manual),
}
);
assert_eq!(
@@ -163,6 +166,12 @@ view_image = false
file: user_file.clone(),
}
);
assert_eq!(
origins.get("tools.execution_mode").expect("origin").name,
ConfigLayerSource::User {
file: user_file.clone(),
}
);
let layers = layers.expect("layers present");
assert_layers_user_then_optional_system(&layers, user_file)?;
@@ -191,6 +191,39 @@ model_reasoning_effort = "high"
Ok(())
}
#[tokio::test]
async fn thread_start_accepts_manual_tool_execution_mode_override() -> Result<()> {
let server = create_mock_responses_server_repeating_assistant("Done").await;
let codex_home = TempDir::new()?;
create_config_toml(codex_home.path(), &server.uri())?;
let mut mcp = McpProcess::new(codex_home.path()).await?;
timeout(DEFAULT_READ_TIMEOUT, mcp.initialize()).await??;
let req_id = mcp
.send_thread_start_request(ThreadStartParams {
config: Some(HashMap::from([(
"tools".to_string(),
json!({
"execution_mode": "manual"
}),
)])),
..Default::default()
})
.await?;
let resp: JSONRPCResponse = timeout(
DEFAULT_READ_TIMEOUT,
mcp.read_stream_until_response_message(RequestId::Integer(req_id)),
)
.await??;
let ThreadStartResponse { thread, .. } = to_response::<ThreadStartResponse>(resp)?;
assert!(!thread.id.is_empty(), "thread id should not be empty");
Ok(())
}
#[tokio::test]
async fn thread_start_accepts_flex_service_tier() -> Result<()> {
let server = create_mock_responses_server_repeating_assistant("Done").await;