mirror of
https://github.com/openai/codex.git
synced 2026-11-15 21:50:46 +00:00
Persist local workspace side chats and add tab close controls (#60152)
## What changed - Save side chats as attachments to their parent conversation when local workspace history supports them, and let users reopen them from the sidebar after a restart. - Show chat names or first-prompt previews in sidebar labels, and allow saved side chats to be renamed with `/rename`. - Add tab close buttons, middle-click closing, and the configurable `close_sidebar_tab` shortcut, defaulting to `Ctrl-X W`. Closing a saved chat keeps it available in the picker; archiving removes it from Side chats. - Confirm actions that stop running work, discard unsent input, or lose temporary history. Delete saved TUI side chats when deleting their parent conversation. ## Testing Add coverage for reopening saved side chats after restart, archive handling, close confirmations, and preventing close-confirmation keys from accepting a replacement approval dialog. GitOrigin-RevId: 3d47533d007286a7354660c08df13a83dd48d5d7
This commit is contained in:
@@ -291,7 +291,8 @@ impl ChatWidget {
|
||||
self.bottom_pane.show_selection_view(SelectionViewParams {
|
||||
title: Some("Delete this session?".to_string()),
|
||||
subtitle: Some(
|
||||
"Cannot be undone. Subagent threads will also be deleted.".to_string(),
|
||||
"Also deletes subagents and saved side chats. Cannot be undone."
|
||||
.to_string(),
|
||||
),
|
||||
footer_hint: Some(standard_popup_hint_line()),
|
||||
items: vec![
|
||||
|
||||
+1
-1
@@ -3,7 +3,7 @@ source: tui/src/chatwidget/tests/slash_commands.rs
|
||||
expression: popup
|
||||
---
|
||||
Delete this session?
|
||||
› As Cannot be undone. Subagent threads will also be deleted.
|
||||
› As Also deletes subagents and saved side chats. Cannot be undone.
|
||||
|
||||
GP
|
||||
› 1. No, keep this session Return to the current
|
||||
|
||||
@@ -322,6 +322,12 @@ impl ChatWidget {
|
||||
None
|
||||
}
|
||||
|
||||
pub(crate) fn has_unsent_input(&self) -> bool {
|
||||
!self.composer_is_empty()
|
||||
|| self.pending_image_submission.is_some()
|
||||
|| self.has_queued_follow_up_messages()
|
||||
}
|
||||
|
||||
pub(crate) fn has_queued_follow_up_messages(&self) -> bool {
|
||||
self.input_queue.has_queued_follow_up_messages()
|
||||
}
|
||||
|
||||
@@ -893,6 +893,12 @@ impl ThreadInputState {
|
||||
);
|
||||
}
|
||||
|
||||
pub(crate) fn has_unsent_input(&self) -> bool {
|
||||
self.composer.is_some()
|
||||
|| !self.queued_user_messages.is_empty()
|
||||
|| !self.rejected_steers_queue.is_empty()
|
||||
}
|
||||
|
||||
pub(crate) fn has_unconfirmed_messages(&self) -> bool {
|
||||
self.queued_user_messages
|
||||
.iter()
|
||||
|
||||
Reference in New Issue
Block a user