From 56e43660f8c8743a43117da53add23c0608e6a8e Mon Sep 17 00:00:00 2001 From: tvh-openai Date: Mon, 16 Nov 2026 23:07:18 +0000 Subject: [PATCH] Default Statsig metrics exports to Zstandard compression (#61911) ## What changed Enable OTLP HTTP Zstandard support and use it by default for the Statsig metrics exporter. Leave compression selection to the SDK when any of `OTEL_EXPORTER_OTLP_COMPRESSION`, `OTEL_EXPORTER_OTLP_METRICS_COMPRESSION`, `OTEL_EXPORTER_OTLP_HEADERS`, or `OTEL_EXPORTER_OTLP_METRICS_HEADERS` is set. GitOrigin-RevId: 67c8088cf35fb95be3618337ea3ad2fe5a75586d --- codex-rs/Cargo.lock | 1 + codex-rs/otel/Cargo.toml | 1 + codex-rs/otel/src/metrics/client.rs | 36 ++++++++++++++++++++++++----- 3 files changed, 32 insertions(+), 6 deletions(-) diff --git a/codex-rs/Cargo.lock b/codex-rs/Cargo.lock index 1098d48e34..5b3393b593 100644 --- a/codex-rs/Cargo.lock +++ b/codex-rs/Cargo.lock @@ -11621,6 +11621,7 @@ dependencies = [ "tokio", "tonic", "tracing", + "zstd", ] [[package]] diff --git a/codex-rs/otel/Cargo.toml b/codex-rs/otel/Cargo.toml index 68c5dce934..fa940558bf 100644 --- a/codex-rs/otel/Cargo.toml +++ b/codex-rs/otel/Cargo.toml @@ -39,6 +39,7 @@ opentelemetry-otlp = { workspace = true, features = [ "reqwest-rustls", "tls", "tls-roots", + "zstd-http", ]} opentelemetry-semantic-conventions = { workspace = true } opentelemetry_sdk = { workspace = true, features = [ diff --git a/codex-rs/otel/src/metrics/client.rs b/codex-rs/otel/src/metrics/client.rs index e5fc11ab79..c21a01db81 100644 --- a/codex-rs/otel/src/metrics/client.rs +++ b/codex-rs/otel/src/metrics/client.rs @@ -19,6 +19,11 @@ use opentelemetry::metrics::Gauge; use opentelemetry::metrics::Histogram; use opentelemetry::metrics::Meter; use opentelemetry::metrics::MeterProvider as _; +use opentelemetry_otlp::Compression; +use opentelemetry_otlp::OTEL_EXPORTER_OTLP_COMPRESSION; +use opentelemetry_otlp::OTEL_EXPORTER_OTLP_HEADERS; +use opentelemetry_otlp::OTEL_EXPORTER_OTLP_METRICS_COMPRESSION; +use opentelemetry_otlp::OTEL_EXPORTER_OTLP_METRICS_HEADERS; use opentelemetry_otlp::OTEL_EXPORTER_OTLP_METRICS_TIMEOUT; use opentelemetry_otlp::Protocol; use opentelemetry_otlp::WithExportConfig; @@ -400,6 +405,7 @@ impl MetricsClient { temporality, &http_client_factory, headers_helper, + /*compression*/ None, )?, policy: http_client_factory.network_policy().clone(), }; @@ -661,15 +667,29 @@ fn build_otlp_metric_exporter( temporality: Temporality, factory: &codex_http_client::HttpClientFactory, headers_helper: Option>, + compression: Option, ) -> Result { match exporter { OtelExporter::None => Err(MetricsError::ExporterDisabled), - OtelExporter::Statsig => build_otlp_metric_exporter( - crate::config::resolve_exporter(&OtelExporter::Statsig), - temporality, - factory, - /*headers_helper*/ None, - ), + OtelExporter::Statsig => { + // Leave explicit OTLP overrides to the SDK. + let compression = [ + OTEL_EXPORTER_OTLP_METRICS_COMPRESSION, + OTEL_EXPORTER_OTLP_COMPRESSION, + OTEL_EXPORTER_OTLP_METRICS_HEADERS, + OTEL_EXPORTER_OTLP_HEADERS, + ] + .into_iter() + .all(|key| std::env::var_os(key).is_none()) + .then_some(Compression::Zstd); + build_otlp_metric_exporter( + crate::config::resolve_exporter(&OtelExporter::Statsig), + temporality, + factory, + /*headers_helper*/ None, + compression, + ) + } OtelExporter::OtlpGrpc { endpoint, headers, @@ -720,6 +740,10 @@ fn build_otlp_metric_exporter( .with_protocol(protocol) .with_headers(headers); + if let Some(compression) = compression { + exporter_builder = exporter_builder.with_compression(compression); + } + if headers_helper.is_some() || factory.network_policy().is_managed() { let client = crate::otlp::build_async_http_client( factory,