mirror of
https://github.com/openai/codex.git
synced 2026-11-20 22:40:37 +00:00
Render streamed Markdown incrementally (#34045)
## Why Streaming TUI responses repeatedly rendered the entire accumulated Markdown source for each committed delta, including blocks whose output could no longer change. ## What changed - Retain rendered output for completed top-level Markdown blocks and rerender only the final mutable block as new source arrives. - Track block boundaries during the existing Markdown parser pass and map them through table-fence normalization. - Preserve canonical full rendering when source-wide state may affect earlier output, including reference link definitions and inline visualizations, and when the width or render mode changes. - Append raw-mode lines directly while preserving blank lines. ## Testing Added coverage that compares incremental output with full rendering across paragraphs, headings, lists, block quotes, code fences, tables, HTML blocks, links, visualizations, render-mode changes, and normalized table fences. GitOrigin-RevId: 748171c4ed58923329b59c48ea3c2afa4819ec88
This commit is contained in:
@@ -106,6 +106,34 @@ pub(crate) fn render_markdown_agent_with_links_cwd_and_visualizations(
|
||||
lines
|
||||
}
|
||||
|
||||
/// Render an agent message and collect the block metadata needed for incremental rendering.
|
||||
///
|
||||
/// Block offsets are mapped back to `markdown_source` after Markdown table fences are unwrapped.
|
||||
/// If a normalized boundary cannot be expressed as a raw-source suffix, it is discarded so the
|
||||
/// transformed block remains mutable.
|
||||
pub(crate) fn render_streaming_markdown_agent_with_links_and_cwd(
|
||||
markdown_source: &str,
|
||||
width: Option<usize>,
|
||||
cwd: Option<&Path>,
|
||||
) -> crate::markdown_render::StreamingMarkdownRender {
|
||||
let normalized = unwrap_markdown_fences(markdown_source);
|
||||
let mut rendered = crate::markdown_render::render_streaming_markdown_lines_with_width_and_cwd(
|
||||
&normalized,
|
||||
width,
|
||||
cwd,
|
||||
);
|
||||
if normalized != markdown_source {
|
||||
// Fence unwrapping removes opening/closing lines. A normalized tail that is still a raw
|
||||
// suffix necessarily begins after those removed lines, so its boundary can safely be
|
||||
// mapped back to the raw source; otherwise leave the transformed block mutable.
|
||||
rendered.last_top_level_block_start = rendered
|
||||
.last_top_level_block_start
|
||||
.and_then(|boundary| markdown_source.strip_suffix(&normalized[boundary..]))
|
||||
.map(str::len);
|
||||
}
|
||||
rendered
|
||||
}
|
||||
|
||||
/// Strip `` ```md ``/`` ```markdown `` fences that contain tables, emitting their content as bare
|
||||
/// markdown so `pulldown-cmark` parses the tables natively.
|
||||
///
|
||||
|
||||
Reference in New Issue
Block a user