From 53015b8d0fe14f4fd4681d565cb6dfa35b2efdf8 Mon Sep 17 00:00:00 2001
From: "Adam Perry @ OpenAI" <anp@openai.com>
Date: Thu, 4 Jun 2026 22:51:00 -0700
Subject: [PATCH] test(rmcp): cover blank OAuth client ids

---
 .../rmcp-client/tests/oauth_auth_status.rs    | 22 +++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/codex-rs/rmcp-client/tests/oauth_auth_status.rs b/codex-rs/rmcp-client/tests/oauth_auth_status.rs
index 1d3e347ad3..17ac1eaf92 100644
--- a/codex-rs/rmcp-client/tests/oauth_auth_status.rs
+++ b/codex-rs/rmcp-client/tests/oauth_auth_status.rs
@@ -39,6 +39,12 @@ async fn blank_access_tokens_are_not_logged_in_without_discovery() -> anyhow::Re
     run_child("whitespace_access_token", "not-a-valid-url").await
 }
 
+#[tokio::test(flavor = "multi_thread", worker_threads = 1)]
+async fn blank_client_ids_are_not_logged_in_without_discovery() -> anyhow::Result<()> {
+    run_child("empty_client_id", "not-a-valid-url").await?;
+    run_child("whitespace_client_id", "not-a-valid-url").await
+}
+
 #[tokio::test(flavor = "multi_thread", worker_threads = 1)]
 async fn blank_refresh_tokens_do_not_make_expired_credentials_usable() -> anyhow::Result<()> {
     run_child("expired_with_empty_refresh", "not-a-valid-url").await?;
@@ -157,6 +163,20 @@ async fn oauth_auth_status_child() -> anyhow::Result<()> {
                 /*expires_at*/ None,
                 McpAuthStatus::NotLoggedIn,
             ),
+            "empty_client_id" => (
+                "access-token",
+                "",
+                /*refresh_token*/ None,
+                /*expires_at*/ None,
+                McpAuthStatus::NotLoggedIn,
+            ),
+            "whitespace_client_id" => (
+                "access-token",
+                " \t ",
+                /*refresh_token*/ None,
+                /*expires_at*/ None,
+                McpAuthStatus::NotLoggedIn,
+            ),
             "expired_with_empty_refresh" => (
                 "expired-access-token",
                 "client-id",
@@ -229,6 +249,8 @@ async fn oauth_auth_status_child() -> anyhow::Result<()> {
         }
         "empty_access_token"
         | "whitespace_access_token"
+        | "empty_client_id"
+        | "whitespace_client_id"
         | "expired_with_empty_refresh"
         | "expired_with_whitespace_refresh"
         | "expired_with_refresh"