mirror of
https://github.com/openai/codex.git
synced 2026-11-15 21:50:46 +00:00
Preserve filesystem authority when loading skills (#59279)
## Why Skill discovery and metadata loading used raw filesystem handles with unrestricted reads, and cache keys distinguished filesystems without accounting for captured permissions. ## What changed - Pass borrowed `EnvironmentAccess` accessors through skill root resolution, discovery, canonicalization, and metadata reads. - Include captured permissions in skill snapshot and empty remote root cache keys. - Add fixed-path watches to `EnvironmentAccess`, falling back to live discovery when read restrictions prevent using unsandboxed executor watches. - Keep user and plugin roots under host filesystem authority independently of the selected repository executor. ## Testing Extend remote root cache coverage to verify that changing captured permissions triggers a fresh scan and that restricted accessors decline unsandboxed watches. GitOrigin-RevId: 97d4bfdfcba78a93fc8845773c6397d4364494e3
This commit is contained in:
committed by
copyberry
parent
afefd0ba95
commit
526f6099f6
@@ -689,8 +689,16 @@ async fn warm_plugins_and_skills_for_session_init(
|
||||
effective_skill_roots,
|
||||
turn_environments,
|
||||
);
|
||||
let access = fs
|
||||
.as_ref()
|
||||
.map(codex_exec_server::FileSystemEnvironmentAccessor::unrestricted);
|
||||
skills_service
|
||||
.snapshot_for_config(&skills_input, fs)
|
||||
.snapshot_for_config(
|
||||
&skills_input,
|
||||
access
|
||||
.as_ref()
|
||||
.map(|access| access as &dyn codex_file_system::EnvironmentAccess),
|
||||
)
|
||||
.await
|
||||
.outcome()
|
||||
.errors
|
||||
|
||||
Reference in New Issue
Block a user