From 517cfb769e912758f4b04071e8c8c8a8707808af Mon Sep 17 00:00:00 2001
From: Eric Traut <etraut@openai.com>
Date: Sat, 11 Apr 2026 04:41:48 -0700
Subject: [PATCH] codex: use literal windows timer ignore reason (#17380)

---
 codex-rs/core/tests/suite/timers.rs | 48 +++++++++++++++++++++--------
 1 file changed, 36 insertions(+), 12 deletions(-)

diff --git a/codex-rs/core/tests/suite/timers.rs b/codex-rs/core/tests/suite/timers.rs
index 857cdae2ff..09b6deb548 100644
--- a/codex-rs/core/tests/suite/timers.rs
+++ b/codex-rs/core/tests/suite/timers.rs
@@ -26,17 +26,20 @@ use pretty_assertions::assert_eq;
 use std::time::Duration;
 
 const TIMER_INTEGRATION_TIMEOUT: Duration = Duration::from_secs(60);
-#[cfg(target_os = "windows")]
-const WINDOWS_BAZEL_IGNORE_REASON: &str =
-    "timer/message integration tests currently exceed the Windows Bazel job timeout";
 
-#[cfg_attr(target_os = "windows", ignore = WINDOWS_BAZEL_IGNORE_REASON)]
+#[cfg_attr(
+    target_os = "windows",
+    ignore = "timer/message integration tests currently exceed the Windows Bazel job timeout"
+)]
 #[tokio::test(flavor = "multi_thread", worker_threads = 2)]
 async fn create_timer_emits_fired_background_event_when_timer_starts() -> Result<()> {
     assert_after_turn_timer_starts_and_emits_fired_event().await
 }
 
-#[cfg_attr(target_os = "windows", ignore = WINDOWS_BAZEL_IGNORE_REASON)]
+#[cfg_attr(
+    target_os = "windows",
+    ignore = "timer/message integration tests currently exceed the Windows Bazel job timeout"
+)]
 #[tokio::test(flavor = "current_thread")]
 async fn create_timer_starts_on_current_thread_runtime() -> Result<()> {
     assert_after_turn_timer_starts_and_emits_fired_event().await
@@ -114,7 +117,10 @@ async fn assert_after_turn_timer_starts_and_emits_fired_event() -> Result<()> {
     Ok(())
 }
 
-#[cfg_attr(target_os = "windows", ignore = WINDOWS_BAZEL_IGNORE_REASON)]
+#[cfg_attr(
+    target_os = "windows",
+    ignore = "timer/message integration tests currently exceed the Windows Bazel job timeout"
+)]
 #[tokio::test(flavor = "multi_thread", worker_threads = 2)]
 async fn create_timer_persists_source_and_client_metadata() -> Result<()> {
     let server = start_mock_server().await;
@@ -160,7 +166,10 @@ async fn create_timer_persists_source_and_client_metadata() -> Result<()> {
     Ok(())
 }
 
-#[cfg_attr(target_os = "windows", ignore = WINDOWS_BAZEL_IGNORE_REASON)]
+#[cfg_attr(
+    target_os = "windows",
+    ignore = "timer/message integration tests currently exceed the Windows Bazel job timeout"
+)]
 #[tokio::test(flavor = "multi_thread", worker_threads = 2)]
 async fn create_timer_rejects_ephemeral_thread() -> Result<()> {
     let server = start_mock_server().await;
@@ -196,7 +205,10 @@ async fn create_timer_rejects_ephemeral_thread() -> Result<()> {
     Ok(())
 }
 
-#[cfg_attr(target_os = "windows", ignore = WINDOWS_BAZEL_IGNORE_REASON)]
+#[cfg_attr(
+    target_os = "windows",
+    ignore = "timer/message integration tests currently exceed the Windows Bazel job timeout"
+)]
 #[tokio::test(flavor = "multi_thread", worker_threads = 2)]
 async fn resume_due_timer_runs_after_history_reconstruction() -> Result<()> {
     let server = start_mock_server().await;
@@ -298,7 +310,10 @@ async fn wait_for_request_containing(mock: &ResponseMock, text: &str) -> Respons
     .unwrap_or_else(|_| panic!("timed out waiting for request containing {text:?}"))
 }
 
-#[cfg_attr(target_os = "windows", ignore = WINDOWS_BAZEL_IGNORE_REASON)]
+#[cfg_attr(
+    target_os = "windows",
+    ignore = "timer/message integration tests currently exceed the Windows Bazel job timeout"
+)]
 #[tokio::test(flavor = "multi_thread", worker_threads = 2)]
 async fn list_timers_discovers_externally_inserted_timer() -> Result<()> {
     let server = start_mock_server().await;
@@ -352,7 +367,10 @@ async fn list_timers_discovers_externally_inserted_timer() -> Result<()> {
     Ok(())
 }
 
-#[cfg_attr(target_os = "windows", ignore = WINDOWS_BAZEL_IGNORE_REASON)]
+#[cfg_attr(
+    target_os = "windows",
+    ignore = "timer/message integration tests currently exceed the Windows Bazel job timeout"
+)]
 #[tokio::test(flavor = "multi_thread", worker_threads = 2)]
 async fn queued_messages_feature_consumes_messages_without_timers() -> Result<()> {
     let server = start_mock_server().await;
@@ -420,7 +438,10 @@ async fn queued_messages_feature_consumes_messages_without_timers() -> Result<()
     Ok(())
 }
 
-#[cfg_attr(target_os = "windows", ignore = WINDOWS_BAZEL_IGNORE_REASON)]
+#[cfg_attr(
+    target_os = "windows",
+    ignore = "timer/message integration tests currently exceed the Windows Bazel job timeout"
+)]
 #[tokio::test(flavor = "multi_thread", worker_threads = 2)]
 async fn queued_message_runs_after_idle_recurring_timer() -> Result<()> {
     let server = start_mock_server().await;
@@ -544,7 +565,10 @@ async fn queued_message_runs_after_idle_recurring_timer() -> Result<()> {
     Ok(())
 }
 
-#[cfg_attr(target_os = "windows", ignore = WINDOWS_BAZEL_IGNORE_REASON)]
+#[cfg_attr(
+    target_os = "windows",
+    ignore = "timer/message integration tests currently exceed the Windows Bazel job timeout"
+)]
 #[tokio::test(flavor = "multi_thread", worker_threads = 2)]
 async fn queued_messages_feature_disabled_leaves_messages_queued() -> Result<()> {
     let server = start_mock_server().await;